DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

Use the appropriate object pool entry type for native functions (makes a JIT app snapshot fail at snapshot creation time instead of runtime).

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/10863a8f0cec739737ce2c52a50ccdc95414200a

[rmacnak, 2016-07-29 20:49:14]

Description was changed from

==========
DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

Use the appropriate object pool entry type for native functions.
==========

to

==========
DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

Use the appropriate object pool entry type for native functions (makes a JIT app
snapshot fail at snapshot creation time instead of runtime).
==========

[rmacnak, 2016-07-29 20:49:37]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2016-07-29 20:56:27]

lgtm w/ question

https://codereview.chromium.org/2196693003/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2196693003/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:789: __
object_pool_wrapper().FindNativeEntry(&label, kNotPatchable);
Are there more places that we should be passing this?

[rmacnak, 2016-07-29 21:08:08]

https://codereview.chromium.org/2196693003/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2196693003/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:789: __
object_pool_wrapper().FindNativeEntry(&label, kNotPatchable);
On 2016/07/29 20:56:27, zra wrote:
> Are there more places that we should be passing this?

This should be the only place with native entry in the pool. It's possible other
places could use kNotPatchable; doing so is a size optimization for sharing
object pool entries.

[rmacnak, 2016-07-29 21:11:31]

Description was changed from

==========
DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

Use the appropriate object pool entry type for native functions (makes a JIT app
snapshot fail at snapshot creation time instead of runtime).
==========

to

==========
DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot.

Use the appropriate object pool entry type for native functions (makes a JIT app
snapshot fail at snapshot creation time instead of runtime).

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/10863a8f0cec739737ce2c52a50ccdc95414200a
==========

[rmacnak, 2016-07-29 21:11:32]

Committed patchset #1 (id:1) manually as
10863a8f0cec739737ce2c52a50ccdc95414200a (presubmit successful).