Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2196693003: DBC: Fail cleanly when attempting to create an AOT or JIT app snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_dbc.cc » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 66894b59bb516d37e98910bf3142f944943142b6..9f0e4509adb96570b12474d6343136e4384e9930 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -6236,6 +6236,8 @@ DART_EXPORT Dart_Handle Dart_Precompile(
bool reset_fields) {
#if defined(TARGET_ARCH_IA32)
return Api::NewError("Precompilation is not supported on IA32.");
+#elif defined(TARGET_ARCH_DBC)
+ return Api::NewError("Precompilation is not supported on DBC.");
#else
API_TIMELINE_BEGIN_END;
DARTSCOPE(Thread::Current());
@@ -6265,7 +6267,9 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotAssembly(
uint8_t** assembly_buffer,
intptr_t* assembly_size) {
#if defined(TARGET_ARCH_IA32)
- return Api::NewError("Snapshots with code are not supported on IA32.");
+ return Api::NewError("Precompilation is not supported on IA32.");
+#elif defined(TARGET_ARCH_DBC)
+ return Api::NewError("Precompilation is not supported on DBC.");
#else
API_TIMELINE_DURATION;
DARTSCOPE(Thread::Current());
@@ -6325,7 +6329,9 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotBlob(
uint8_t** rodata_blob_buffer,
intptr_t* rodata_blob_size) {
#if defined(TARGET_ARCH_IA32)
- return Api::NewError("Snapshots with code are not supported on IA32.");
+ return Api::NewError("Precompilation is not supported on IA32.");
+#elif defined(TARGET_ARCH_DBC)
+ return Api::NewError("Precompilation is not supported on DBC.");
#else
API_TIMELINE_DURATION;
DARTSCOPE(Thread::Current());
@@ -6427,6 +6433,8 @@ DART_EXPORT Dart_Handle Dart_CreateAppJITSnapshot(
intptr_t* rodata_blob_size) {
#if defined(TARGET_ARCH_IA32)
return Api::NewError("Snapshots with code are not supported on IA32.");
+#elif defined(TARGET_ARCH_DBC)
+ return Api::NewError("Snapshots with code are not supported on DBC.");
#else
API_TIMELINE_DURATION;
DARTSCOPE(Thread::Current());
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_dbc.cc » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698