components/tracing/core/trace_ring_buffer_unittest.cc - Issue 2196663002: tracing v2: Introduce TraceBufferWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/trace_ring_buffer_unittest.cc

Issue 2196663002: tracing v2: Introduce TraceBufferWriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proto_refactor

Patch Set: Fix linking errors moving kChunkSize outside of exported class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/core/trace_ring_buffer_unittest.cc

diff --git a/components/tracing/core/trace_ring_buffer_unittest.cc b/components/tracing/core/trace_ring_buffer_unittest.cc

index 34104bd15459a8e9a5da79c704ce027ea27f2a82..5a1a41b3b1303abd9dcac220a8fc882ad4ce7fa7 100644

--- a/components/tracing/core/trace_ring_buffer_unittest.cc

+++ b/components/tracing/core/trace_ring_buffer_unittest.cc

@@ -11,8 +11,6 @@ namespace v2 {

namespace {

-const size_t kChunkSize = TraceRingBuffer::Chunk::kSize;

TEST(TraceRingBufferTest, BasicChunkWrapping) {

const uint32_t kNumChunks = 5;

const size_t kBufferSize = kChunkSize * kNumChunks;

@@ -50,7 +48,7 @@ TEST(TraceRingBufferTest, BasicChunkWrapping) {

TEST(TraceRingBufferTest, ChunkBankrupcyDoesNotCrash) {

const size_t kNumChunks = 2;

- const size_t kBufferSize = TraceRingBuffer::Chunk::kSize * kNumChunks;

+ const size_t kBufferSize = kChunkSize * kNumChunks;

std::unique_ptr<uint8_t[]> storage(new uint8_t[kBufferSize]);

TraceRingBuffer ring_buffer(storage.get(), kBufferSize);