Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: components/tracing/core/trace_ring_buffer.cc

Issue 2196663002: tracing v2: Introduce TraceBufferWriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proto_refactor
Patch Set: Fix linking errors moving kChunkSize outside of exported class Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/core/trace_ring_buffer.h ('k') | components/tracing/core/trace_ring_buffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/core/trace_ring_buffer.cc
diff --git a/components/tracing/core/trace_ring_buffer.cc b/components/tracing/core/trace_ring_buffer.cc
index c206ed3f647c7f8af8082ef0af49e0cb4a0c5b1d..582ed279ccce3e3a09bca84d267933fc9ede8b11 100644
--- a/components/tracing/core/trace_ring_buffer.cc
+++ b/components/tracing/core/trace_ring_buffer.cc
@@ -10,7 +10,7 @@ namespace tracing {
namespace v2 {
TraceRingBuffer::TraceRingBuffer(uint8_t* begin, size_t size)
- : num_chunks_(size / Chunk::kSize),
+ : num_chunks_(size / kChunkSize),
num_chunks_taken_(0),
current_chunk_idx_(0) {
DCHECK_GT(num_chunks_, 0u);
@@ -19,7 +19,7 @@ TraceRingBuffer::TraceRingBuffer(uint8_t* begin, size_t size)
uint8_t* chunk_begin = begin;
for (size_t i = 0; i < num_chunks_; ++i) {
chunks_[i].Initialize(chunk_begin);
- chunk_begin += Chunk::kSize;
+ chunk_begin += kChunkSize;
}
}
@@ -43,7 +43,7 @@ TraceRingBuffer::Chunk* TraceRingBuffer::TakeChunk(uint32_t writer_id) {
// Bankrupcy: there are more threads than chunks. All chunks were in flight.
if (!bankrupcy_chunk_storage_) {
- bankrupcy_chunk_storage_.reset(new uint8_t[Chunk::kSize]);
+ bankrupcy_chunk_storage_.reset(new uint8_t[kChunkSize]);
bankrupcy_chunk_.Initialize(&bankrupcy_chunk_storage_.get()[0]);
}
bankrupcy_chunk_.Clear();
« no previous file with comments | « components/tracing/core/trace_ring_buffer.h ('k') | components/tracing/core/trace_ring_buffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698