components/tracing/core/scattered_stream_writer.h - Issue 2196663002: tracing v2: Introduce TraceBufferWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/scattered_stream_writer.h

Issue 2196663002: tracing v2: Introduce TraceBufferWriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proto_refactor

Patch Set: Fix linking errors moving kChunkSize outside of exported class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/core/scattered_stream_writer.h

diff --git a/components/tracing/core/scattered_stream_writer.h b/components/tracing/core/scattered_stream_writer.h

index 8fbf84cbeb2c7330bbc6fb821c8fc130cf01dca7..53fcd881dcd098972a6f572d57129fe3db4e17fe 100644

--- a/components/tracing/core/scattered_stream_writer.h

+++ b/components/tracing/core/scattered_stream_writer.h

@@ -38,8 +38,9 @@ struct ContiguousMemoryRange {

// ContiguousMemoryRange and defers the chunk-chaining logic to the Delegate.

class TRACING_EXPORT ScatteredStreamWriter {

public:

- class Delegate {

+ class TRACING_EXPORT Delegate {

public:

+ virtual ~Delegate();

virtual ContiguousMemoryRange GetNewBuffer() = 0;

};