components/tracing/core/proto_zero_message.h - Issue 2196663002: tracing v2: Introduce TraceBufferWriter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/core/proto_zero_message.h

Issue 2196663002: tracing v2: Introduce TraceBufferWriter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proto_refactor

Patch Set: Fix linking errors moving kChunkSize outside of exported class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/core/proto_zero_message.h

diff --git a/components/tracing/core/proto_zero_message.h b/components/tracing/core/proto_zero_message.h

index d7fe1d4270e5a99474e940091f39dd69ac5ee4bf..bbc21cacbb8e76098a160ec6a21748a876929eb9 100644

--- a/components/tracing/core/proto_zero_message.h

+++ b/components/tracing/core/proto_zero_message.h

@@ -29,6 +29,8 @@ class ProtoZeroMessageHandleBase;

// performance. None of the methods require any dynamic memory allocation.

class TRACING_EXPORT ProtoZeroMessage {

public:

+ ProtoZeroMessage();

// Clears up the state, allowing the message to be reused as a fresh one.

void Reset(ScatteredStreamWriter*);

@@ -59,8 +61,6 @@ class TRACING_EXPORT ProtoZeroMessage {

#endif

protected:

- ProtoZeroMessage();

void AppendVarIntU64(uint32_t field_id, uint64_t value);

void AppendVarIntU32(uint32_t field_id, uint32_t value);

void AppendFloat(uint32_t field_id, float value);