Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2196393006: Remove search::ShouldAllowPrefetchNonDefaultMatch (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_prerender_omnibox
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove search::ShouldAllowPrefetchNonDefaultMatch It's an abandoned field trial and so always false in practice. BUG=627483 Committed: https://crrev.com/1e2b69585730d1cb5eb196af56fa29beccb7cbe0 Cr-Commit-Position: refs/heads/master@{#410020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -46 lines) Patch
M chrome/browser/ui/omnibox/chrome_omnibox_client.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M components/search/search.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/search/search.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M components/search/search_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Marc Treib
One more :) PTAL!
4 years, 4 months ago (2016-08-04 11:06:52 UTC) #3
Peter Kasting
LGTM
4 years, 4 months ago (2016-08-04 23:36:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196393006/1
4 years, 4 months ago (2016-08-05 09:15:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 09:19:12 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 09:20:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e2b69585730d1cb5eb196af56fa29beccb7cbe0
Cr-Commit-Position: refs/heads/master@{#410020}

Powered by Google App Engine
This is Rietveld 408576698