Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2152743002: Remove search::ShouldPrerenderInstantUrlOnOmniboxFocus (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
kmadhusu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_prefetch_srp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove search::ShouldPrerenderInstantUrlOnOmniboxFocus and related code. It's always false in practice. BUG=627483 Committed: https://crrev.com/3272f3156022db606c12e33376a513609d15ba0d Cr-Commit-Position: refs/heads/master@{#409738}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -168 lines) Patch
M chrome/browser/search/search.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/search/search.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 4 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 7 chunks +2 lines, -40 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 3 chunks +0 lines, -76 lines 0 comments Download

Depends on Patchset:

Issue 2143953002 Patch 40001

Dependent Patchsets:

Issue 2196393006 Patch 1

Messages

Total messages: 12 (7 generated)
Marc Treib
Next one - PTAL!
4 years, 4 months ago (2016-08-03 10:05:35 UTC) #4
kmadhusu
lgtm
4 years, 4 months ago (2016-08-03 18:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152743002/20001
4 years, 4 months ago (2016-08-04 08:19:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 08:23:11 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:25:12 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3272f3156022db606c12e33376a513609d15ba0d
Cr-Commit-Position: refs/heads/master@{#409738}

Powered by Google App Engine
This is Rietveld 408576698