third_party/WebKit/Source/web/WebDataSourceImpl.cpp - Issue 2196333002: PlzNavigate: Clear provisional history item on redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDataSourceImpl.cpp

Issue 2196333002: PlzNavigate: Clear provisional history item on redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timing_api

Patch Set: Addressed comments (2) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FrameLoader.cpp ('K') | « third_party/WebKit/Source/web/WebDataSourceImpl.h ('k') | third_party/WebKit/public/web/WebDataSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebDataSourceImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDataSourceImpl.cpp b/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

index 70e1d4193b6451c383b0ad4d3b1dadbcb9cc1f02..1772d017f5f785f0f157a9a55a58e61930579d6d 100644

--- a/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

@@ -75,10 +75,10 @@ void WebDataSourceImpl::appendRedirect(const WebURL& url)

DocumentLoader::appendRedirect(url);

}

-void WebDataSourceImpl::updateNavigationTimings(double redirectStartTime, double redirectEndTime, double fetchStartTime, const WebVector<WebURL>& redirectChain)

+void WebDataSourceImpl::updateNavigation(double redirectStartTime, double redirectEndTime, double fetchStartTime, const WebVector<WebURL>& redirectChain)

{

for (size_t i = 0; i + 1 < redirectChain.size(); ++i)

- timing().addRedirect(redirectChain[i], redirectChain[i + 1]);

+ didRedirect(redirectChain[i], redirectChain[i + 1]);

timing().setRedirectStart(redirectStartTime);

timing().setRedirectEnd(redirectEndTime);

timing().setFetchStart(fetchStartTime);