third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2196333002: PlzNavigate: Clear provisional history item on redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2196333002: PlzNavigate: Clear provisional history item on redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timing_api

Patch Set: Addressed comments (2) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.h ('k') | third_party/WebKit/Source/web/WebDataSourceImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index f0076ae811104f7e54b8937d483223412fe1669a..b653cff3e338d5b69403035efc8f4de2ed5886f4 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -376,6 +376,11 @@ void FrameLoader::receivedMainResourceRedirect(const KURL& newURL)

client()->dispatchDidReceiveServerRedirectForProvisionalLoad();

// If a back/forward navigation redirects, don't reuse any state from the HistoryItem.

+ discardProvisionalHistoryItem();

+void FrameLoader::discardProvisionalHistoryItem()

Nate Chapin 2016/08/17 23:45:52 Nit: clearProvisionalHistoryItem(), for maximum ac

arthursonzogni 2016/08/18 09:21:38 Done.

m_provisionalItem.clear();

}