PlzNavigate: Clear provisional history item on redirects.

third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Index: third_party/WebKit/Source/core/loader/DocumentLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
index 89f4ce5200c44ef3153caedbc6ca774f0abc10bf..9bfd75a12796024dae78e0e901303167390625d0 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
@@ -209,6 +209,18 @@ Resource* DocumentLoader::startPreload(Resource::Type type, FetchRequest& reques
     return resource;
 }
 
+void DocumentLoader::didRedirect(const KURL& oldURL, const KURL& newURL)

[Nate Chapin, 2016/08/17 23:45:52]

Is there some redundant code between this and redirectReceived now? Can we have
redirectReceived call didRedirect, esp. if
FrameLoader::receivedMainResourceRedirect gets inlined in responseReceived?

[arthursonzogni, 2016/08/18 09:21:38]

I tried to use didRedirect in redirectReceived.
Now the provisionalHistoryItem is cleared in only one place.
It is much better like this. Thanks!

+{
+    timing().addRedirect(oldURL, newURL);
+
+    // If a redirection happens during a back/forward navigation, don't restore
+    // any state from the old HistoryItem.
+    // There is a provisional history item for back/forward navigation only.
+    // In the other case, clearing it is a no-op.
+    DCHECK(frameLoader());
+    frameLoader()->discardProvisionalHistoryItem();
+}
+
 void DocumentLoader::dispatchLinkHeaderPreloads(ViewportDescriptionWrapper* viewport, LinkLoader::MediaPreloadPolicy mediaPolicy)
 {
     LinkLoader::loadLinksFromHeader(response().httpHeaderField(HTTPNames::Link), response().url(), m_frame->document(), NetworkHintsInterfaceImpl(), LinkLoader::OnlyLoadResources, mediaPolicy, viewport);