Skips processing more SavePageLater requests in current processing window when one completes unsucc…

components/offline_pages/background/request_coordinator.cc

Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 5876d8386d79b7c3834f6cf9b7d72bd22f8c38cd..39cb7e6bf35e724e31c17fb8d282bfa8949fd8d8 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -228,7 +228,15 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
                    weak_ptr_factory_.GetWeakPtr()));
   }
 
-  TryNextRequest();
+  // Determine whether we might try another request in this
+  // processing window based on how the previous request completed.
+  //
+  // TODO(dougarnett): Support trying another request for some
+  // whitelisted types of rendering failures (but not for cancels
+  // or rendering process killed).
+  if (status == Offliner::RequestStatus::SAVED) {

[Pete Williamson, 2016/08/01 19:56:27]

Let's fix this right while we are here.
THere aren't all that many cases:
   REQUEST_COORDINATOR_CANCELED - Let's try the next one.
    PRERENDERING_CANCELED - Presumably this happens because the user started
using the device, so don't continue.

    PRERENDERING_FAILED - If it was the page's fault, try the next one.  If the
prerenderer crashed, abort.  Can we tell the difference?

    SAVE_FAILED - Let's try the next one, then.

    FOREGROUND_CANCELED - Not sure how this is different than
PRERENDERING_CANCELLED.

+    TryNextRequest();
+  }
 }
 
 const Scheduler::TriggerConditions