Skips processing more SavePageLater requests in current processing window when one completes unsucc…

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 210 matching lines @@
     updated_request.set_last_attempt_time(base::Time::Now());
     RequestQueue::UpdateRequestCallback update_callback =
         base::Bind(&RequestCoordinator::UpdateRequestCallback,
                    weak_ptr_factory_.GetWeakPtr());
     queue_->UpdateRequest(
         updated_request,
         base::Bind(&RequestCoordinator::UpdateRequestCallback,
                    weak_ptr_factory_.GetWeakPtr()));
   }
 
-  TryNextRequest();
+  // Determine whether we might try another request in this
+  // processing window based on how the previous request completed.
+  //
+  // TODO(dougarnett): Support trying another request for some
+  // whitelisted types of rendering failures (but not for cancels
+  // or rendering process killed).
+  if (status == Offliner::RequestStatus::SAVED) {

[Pete Williamson, 2016/08/01 19:56:27]

Let's fix this right while we are here.
THere aren't all that many cases:
   REQUEST_COORDINATOR_CANCELED - Let's try the next one.
    PRERENDERING_CANCELED - Presumably this happens because the user started
using the device, so don't continue.

    PRERENDERING_FAILED - If it was the page's fault, try the next one.  If the
prerenderer crashed, abort.  Can we tell the difference?

    SAVE_FAILED - Let's try the next one, then.

    FOREGROUND_CANCELED - Not sure how this is different than
PRERENDERING_CANCELLED.

+    TryNextRequest();
+  }
 }
 
 const Scheduler::TriggerConditions
 RequestCoordinator::GetTriggerConditionsForUserRequest() {
   Scheduler::TriggerConditions trigger_conditions(
       policy_->PowerRequiredForUserRequestedPage(),
       policy_->BatteryPercentageRequiredForUserRequestedPage(),
       policy_->UnmeteredNetworkRequiredForUserRequestedPage());
   return trigger_conditions;
 }
 
 void RequestCoordinator::GetOffliner() {
   if (!offliner_) {
     offliner_ = factory_->GetOffliner(policy_.get());
   }
 }
 
 }  // namespace offline_pages