Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2196243002: GN: Define SK_HAS_... in all Skia-private code, not just libskia. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Define SK_HAS_... in all Skia-private code, not just libskia. SkForceLinking wasn't force-linking the WEBP encoder, or any encoder. (The others must be explicitly used.) This should help the GN Debug Perf bots progress past Running Encode_color_wheel.jpg_WEBP nonrendering ../../../bench/EncoderBench.cpp:58: fatal error: "assert(data)" On my laptop, a debug nanobench run now finishes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196243002 Committed: https://skia.googlesource.com/skia/+/150d113db56dc55b5e78f32febfb1e3b7c350611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 4 months ago (2016-08-01 13:37:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196243002/1
4 years, 4 months ago (2016-08-01 13:38:06 UTC) #6
jcgregorio
lgtm
4 years, 4 months ago (2016-08-01 13:43:04 UTC) #7
jcgregorio
lgtm
4 years, 4 months ago (2016-08-01 13:48:33 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:56:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/150d113db56dc55b5e78f32febfb1e3b7c350611

Powered by Google App Engine
This is Rietveld 408576698