BUILD.gn - Issue 2196243002: GN: Define SK_HAS_... in all Skia-private code, not just libskia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2196243002: GN: Define SK_HAS_... in all Skia-private code, not just libskia. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index d6e25626b3a4dfa131757be16a095ad7b2ccda6e..8c519d929e8649323075e11b4137e31d32d90f47 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -56,6 +56,13 @@ config("skia_private") {

"third_party/etc1",

"third_party/ktx",

]

+ defines = [

+ "SK_HAS_GIF_LIBRARY",

+ "SK_HAS_JPEG_LIBRARY",

+ "SK_HAS_PNG_LIBRARY",

+ "SK_HAS_WEBP_LIBRARY",

+ ]

}

# Any code that's linked into Skia-the-library should use this config via += skia_library_configs.

@@ -161,13 +168,6 @@ component("skia") {

"//third_party/zlib",

]

- defines = [

- "SK_HAS_GIF_LIBRARY",

- "SK_HAS_JPEG_LIBRARY",

- "SK_HAS_PNG_LIBRARY",

- "SK_HAS_WEBP_LIBRARY",

- ]

libs = [ "pthread" ]

sources = []

« no previous file with comments | « no previous file | no next file » | no next file with comments »