Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2195903002: Add Double{Size, Point, Rect} pretty printers for logging and testing (Closed)

Created:
4 years, 4 months ago by pdr.
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@geometryPrettyPrinters2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Double{Size, Point, Rect} pretty printers for logging and testing This patch unifies the pretty printers for DoubleSize, DoublePoint, and DoubleRect with the approach used for LayoutRect, FloatRect, etc. For example, to print the value of a DoubleRect: DoubleRect rect(1, 2, 3, 4); LOG(INFO) << "rect: " << rect; Which prints: rect: "1,2 3x4" BUG=632096 Committed: https://crrev.com/543079b35d7fedda30a4bc17c286038a71c81307 Cr-Commit-Position: refs/heads/master@{#413569}

Patch Set 1 #

Patch Set 2 : Rebase and update #

Patch Set 3 : Remove unnecessary String casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/geometry/DoublePoint.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoublePoint.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoubleRect.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoubleRect.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoubleRectTest.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoubleSize.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/DoubleSize.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/GeometryPrinters.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
pdr.
4 years, 4 months ago (2016-07-29 22:31:37 UTC) #2
chrishtr
lgtm
4 years, 4 months ago (2016-07-30 00:10:03 UTC) #5
pdr.
Updated per the new approach in https://codereview.chromium.org/2191233002 of using toString() instead of operator<<. PTAL
4 years, 4 months ago (2016-08-21 01:27:08 UTC) #14
chrishtr
Per offline conversation, please try adding the ostream operators in a followup to avoid making ...
4 years, 4 months ago (2016-08-22 23:05:15 UTC) #19
chrishtr
lgtm
4 years, 4 months ago (2016-08-22 23:05:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195903002/40001
4 years, 4 months ago (2016-08-22 23:06:32 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 23:11:40 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:15:13 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/543079b35d7fedda30a4bc17c286038a71c81307
Cr-Commit-Position: refs/heads/master@{#413569}

Powered by Google App Engine
This is Rietveld 408576698