third_party/WebKit/Source/platform/geometry/DoubleRect.h - Issue 2195903002: Add Double{Size, Point, Rect} pretty printers for logging and testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/DoubleRect.h

Issue 2195903002: Add Double{Size, Point, Rect} pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@geometryPrettyPrinters2

Patch Set: Remove unnecessary String casts Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/geometry/DoublePoint.cpp ('k') | third_party/WebKit/Source/platform/geometry/DoubleRect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/DoubleRect.h

diff --git a/third_party/WebKit/Source/platform/geometry/DoubleRect.h b/third_party/WebKit/Source/platform/geometry/DoubleRect.h

index 1af7ac9f3142ab68768e23f50e5c6202fb85597c..311676943f77c1268d008fd686e7d4fdcd4980e5 100644

--- a/third_party/WebKit/Source/platform/geometry/DoubleRect.h

+++ b/third_party/WebKit/Source/platform/geometry/DoubleRect.h

@@ -61,9 +61,7 @@ public:

void scale(float s) { scale(s, s); }

void scale(float sx, float sy);

-#ifndef NDEBUG

String toString() const;

-#endif

private:

DoublePoint m_location;

@@ -77,6 +75,10 @@ PLATFORM_EXPORT IntRect enclosedIntRect(const DoubleRect&);

PLATFORM_EXPORT IntRect roundedIntRect(const DoubleRect&);

+// Redeclared here to avoid ODR issues.

+// See platform/testing/GeometryPrinters.h.

+void PrintTo(const DoubleRect&, std::ostream*);

} // namespace blink

#endif