Migrate SchedulerWorkerPoolImpl to AtomicFlag

Migrate SchedulerWorkerPoolImpl to AtomicFlag

BUG=553459
Committed: https://crrev.com/74d2f746deaddefc3ed2299e2bc1dd4222977265
Cr-Commit-Position: refs/heads/master@{#408768}

[robliao, 2016-07-29 18:51:17]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[gab, 2016-07-29 19:04:39]

I'd prefer to flip the logic as mentioned over chat (i.e. only Set() in the
non-default case).

[fdoray, 2016-07-29 19:07:05]

On 2016/07/29 19:04:39, gab wrote:
> I'd prefer to flip the logic as mentioned over chat (i.e. only Set() in the
> non-default case).

+1

[robliao, 2016-07-29 19:31:39]

On 2016/07/29 19:07:05, fdoray wrote:
> On 2016/07/29 19:04:39, gab wrote:
> > I'd prefer to flip the logic as mentioned over chat (i.e. only Set() in the
> > non-default case).
> 
> +1

My preference is to avoid double-negatives as they on the whole make code slower
to read.
Changed for this case.

[gab, 2016-07-29 19:36:00]

On 2016/07/29 19:31:39, robliao wrote:
> On 2016/07/29 19:07:05, fdoray wrote:
> > On 2016/07/29 19:04:39, gab wrote:
> > > I'd prefer to flip the logic as mentioned over chat (i.e. only Set() in
the
> > > non-default case).
> > 
> > +1
> 
> My preference is to avoid double-negatives as they on the whole make code
slower
> to read.
> Changed for this case.

Agreed but in this specific case I think it's better because it's an AtomicFlag,
not a boolean.

lgtm, thanks

[robliao, 2016-07-29 19:37:52]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 19:38:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-07-29 20:05:53]

lgtm

[commit-bot: I haz the power, 2016-07-29 20:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:44:02]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-07-29 20:46:45]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:47:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:27:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 21:29:18]

Description was changed from

==========
Migrate SchedulerWorkerPoolImpl to AtomicFlag

BUG=553459
==========

to

==========
Migrate SchedulerWorkerPoolImpl to AtomicFlag

BUG=553459

Committed: https://crrev.com/74d2f746deaddefc3ed2299e2bc1dd4222977265
Cr-Commit-Position: refs/heads/master@{#408768}
==========

[commit-bot: I haz the power, 2016-07-29 21:29:19]

Patchset 2 (id:??) landed as
https://crrev.com/74d2f746deaddefc3ed2299e2bc1dd4222977265
Cr-Commit-Position: refs/heads/master@{#408768}