Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2195813002: Migrate SchedulerWorkerPoolImpl to AtomicFlag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index cd50c95ca2634db8921e2a49e1692662767561e3..b97ce8dd1981ab440058cc96a0fd8bfaa204d0ff 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -278,8 +278,7 @@ void SchedulerWorkerPoolImpl::JoinForTesting() {
}
void SchedulerWorkerPoolImpl::DisallowWorkerDetachmentForTesting() {
- AutoSchedulerLock auto_lock(worker_detachment_allowed_lock_);
- worker_detachment_allowed_ = false;
+ worker_detachment_disallowed_.Set();
}
scoped_refptr<TaskRunner> SchedulerWorkerPoolImpl::CreateTaskRunnerWithTraits(
@@ -638,8 +637,7 @@ void SchedulerWorkerPoolImpl::RemoveFromIdleWorkersStack(
}
bool SchedulerWorkerPoolImpl::CanWorkerDetachForTesting() {
- AutoSchedulerLock auto_lock(worker_detachment_allowed_lock_);
- return worker_detachment_allowed_;
+ return !worker_detachment_disallowed_.IsSet();
}
} // namespace internal
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698