Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2195793003: MD Settings: add test for managed actionability of people section (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@people-sync-disabled-actionable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add test for managed actionability of people section R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/91307343c94e876ef1951063c0ef5a53a0f2ca85 Cr-Commit-Position: refs/heads/master@{#408753}

Patch Set 1 #

Total comments: 2

Patch Set 2 : tommycli@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/people_page_test.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Dan Beam
4 years, 4 months ago (2016-07-29 19:14:59 UTC) #2
tommycli
lgtm with nit: https://codereview.chromium.org/2195793003/diff/1/chrome/test/data/webui/settings/people_page_test.js File chrome/test/data/webui/settings/people_page_test.js (right): https://codereview.chromium.org/2195793003/diff/1/chrome/test/data/webui/settings/people_page_test.js#newcode218 chrome/test/data/webui/settings/people_page_test.js:218: test('ManagedSyncDisabled', function() { Name instead: CustomizeSync ...
4 years, 4 months ago (2016-07-29 19:25:22 UTC) #5
Dan Beam
https://codereview.chromium.org/2195793003/diff/1/chrome/test/data/webui/settings/people_page_test.js File chrome/test/data/webui/settings/people_page_test.js (right): https://codereview.chromium.org/2195793003/diff/1/chrome/test/data/webui/settings/people_page_test.js#newcode218 chrome/test/data/webui/settings/people_page_test.js:218: test('ManagedSyncDisabled', function() { On 2016/07/29 19:25:22, tommycli wrote: > ...
4 years, 4 months ago (2016-07-29 19:27:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195793003/20001
4 years, 4 months ago (2016-07-29 19:27:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 21:15:39 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:18:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91307343c94e876ef1951063c0ef5a53a0f2ca85
Cr-Commit-Position: refs/heads/master@{#408753}

Powered by Google App Engine
This is Rietveld 408576698