Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2178303003:
MD Settings: disable cursor: pointer when sync is disabled (Closed)
|
Created:
4 years, 4 months ago by Dan Beam Modified:
4 years, 4 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: disable cursor: pointer when sync is disabled
R=tommycli@chromium.org
BUG=629604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/952e2e28ee1501c58d1de1830792418805c245ab
Cr-Commit-Position: refs/heads/master@{#408716}
Patch Set 1 #
Total comments: 2
Patch Set 2 : tommycli@ review #
Total comments: 2
Patch Set 3 : simplest #
Dependent Patchsets: Messages
Total messages: 22 (13 generated)
Description was changed from ========== MD Settings: disable cursor: pointer when sync is disable R=tommycli@chromium.org BUG=629604 ========== to ========== MD Settings: disable cursor: pointer when sync is disable R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2178303003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/people_page.js (right): https://codereview.chromium.org/2178303003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/people_page.js:318: return !(syncStatus && syncStatus.managed); It seems that this should be: !syncStatus || syncStatus.managed It seems that if we haven't retrieved the sync status it should also be not actionable yet right?
https://codereview.chromium.org/2178303003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/people_page.js (right): https://codereview.chromium.org/2178303003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/people_page.js:318: return !(syncStatus && syncStatus.managed); On 2016/07/26 23:51:13, tommycli wrote: > It seems that this should be: > > !syncStatus || syncStatus.managed > > It seems that if we haven't retrieved the sync status it should also be not > actionable yet right? Err.. i guess actually: syncStatus && !syncStatus.managed.
Description was changed from ========== MD Settings: disable cursor: pointer when sync is disable R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2178303003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2178303003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/people_page.html:127: if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]"> this requires a non-null syncStatus, so I've simplified the code
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2178303003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2178303003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/people_page.html:127: if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]"> On 2016/07/29 03:45:05, Dan Beam wrote: > this requires a non-null syncStatus, so I've simplified the code Thanks!
tests are here: https://codereview.chromium.org/2195793003/
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/952e2e28ee1501c58d1de1830792418805c245ab Cr-Commit-Position: refs/heads/master@{#408716} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/952e2e28ee1501c58d1de1830792418805c245ab Cr-Commit-Position: refs/heads/master@{#408716} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
