GN: only write targets that should be generated.

GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were resolved but didn't have the "should generate" bit set. The "should generate" bit will be unset for things in non-default toolchains that aren't required to build anything in the main toolchain. This set of things is small since most things will have incomplete deps if they're not required. But it comes up for a few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were written to the main ninja file, so the extra files were just unreferenced. The recent change that moves more stuff into the main file rather than subninjas exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should generate" is set.

Committed: https://crrev.com/da21696cd246f78f66bdb5d6f6aa9deadf2e6abc
Cr-Commit-Position: refs/heads/master@{#408676}

[brettw, 2016-07-29 16:52:50]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-07-29 16:52:54]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 16:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-07-29 17:03:35]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-07-29 17:03:38]

lgtm

[brettw, 2016-07-29 17:05:34]

Description was changed from

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.
==========

to

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.
==========

[brettw, 2016-07-29 17:05:34]

brettw@chromium.org changed reviewers:
- dpranke@chromium.org

[brettw, 2016-07-29 17:05:38]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-07-29 17:05:41]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:06:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:26:57]

Description was changed from

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.
==========

to

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.
==========

[commit-bot: I haz the power, 2016-07-29 17:27:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 17:28:50]

Description was changed from

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.
==========

to

==========
GN: only write targets that should be generated.

Apparently forever GN has been writing .ninja files for targets that were
resolved but didn't have the "should generate" bit set. The "should generate"
bit will be unset for things in non-default toolchains that aren't required to
build anything in the main toolchain. This set of things is small since most
things will have incomplete deps if they're not required. But it comes up for a
few NaCl copy rules.

The extra files were never a problem because only "should generate" targets were
written to the main ninja file, so the extra files were just unreferenced. The
recent change that moves more stuff into the main file rather than subninjas
exposed the bug, which now appears as multiply-defined targets.

This fix only issues the callback when an item is both resolved and "should
generate" is set.

Committed: https://crrev.com/da21696cd246f78f66bdb5d6f6aa9deadf2e6abc
Cr-Commit-Position: refs/heads/master@{#408676}
==========

[commit-bot: I haz the power, 2016-07-29 17:28:50]

Patchset 1 (id:??) landed as
https://crrev.com/da21696cd246f78f66bdb5d6f6aa9deadf2e6abc
Cr-Commit-Position: refs/heads/master@{#408676}

[Dirk Pranke, 2016-07-29 23:51:35]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-07-29 23:51:35]

lgtm