Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/gn/command_gen.cc

Issue 2195753002: GN: only write targets that should be generated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index 7de9aedeeec7be261149e5d4e310f6353abd02d3..60735f8dfa9d577ba33eee1c5672335cb623ec61 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -67,8 +67,8 @@ void BackgroundDoWrite(TargetWriteInfo* write_info, const Target* target) {
}
// Called on the main thread.
-void ItemResolvedCallback(TargetWriteInfo* write_info,
- const BuilderRecord* record) {
+void ItemResolvedAndGeneratedCallback(TargetWriteInfo* write_info,
+ const BuilderRecord* record) {
const Item* item = record->item();
const Target* target = item->AsTarget();
if (target) {
@@ -387,8 +387,8 @@ int RunGen(const std::vector<std::string>& args) {
// Cause the load to also generate the ninja files for each target.
TargetWriteInfo write_info;
- setup->builder().set_resolved_callback(
- base::Bind(&ItemResolvedCallback, &write_info));
+ setup->builder().set_resolved_and_generated_callback(
+ base::Bind(&ItemResolvedAndGeneratedCallback, &write_info));
// Do the actual load. This will also write out the target ninja files.
if (!setup->Run())
« no previous file with comments | « tools/gn/builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698