Simplify some FPDF edit functions.

Simplify some FPDF edit functions.

Fix an unlikely memory leak in FPDFPage_InsertObject().

BUG=pdfium:545
Committed: https://pdfium.googlesource.com/pdfium/+/c54bb4340324fab9e860fd625b4b380b6135c385

[Lei Zhang, 2016-07-29 08:45:52]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 08:46:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-29 08:54:35]

Description was changed from

==========
Simplify some FPDF edit functions.
==========

to

==========
Simplify some FPDF edit functions.

Fix an unlikely memory leak in FPDFPage_InsertObject().

BUG=pdfium:545
==========

[Lei Zhang, 2016-07-29 08:54:35]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[commit-bot: I haz the power, 2016-07-29 08:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 08:58:51]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-07-29 13:22:50]

https://codereview.chromium.org/2195643002/diff/1/core/fpdfapi/fpdf_page/incl...
File core/fpdfapi/fpdf_page/include/cpdf_formobject.h (right):

https://codereview.chromium.org/2195643002/diff/1/core/fpdfapi/fpdf_page/incl...
core/fpdfapi/fpdf_page/include/cpdf_formobject.h:33: std::unique_ptr<CPDF_Form>
m_pForm;
Can these be made private: now?

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditimg.cpp
File fpdfsdk/fpdfeditimg.cpp (right):

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditimg.cpp#new...
fpdfsdk/fpdfeditimg.cpp:22: pImageObj->m_pImage = new CPDF_Image(pDoc);
Should this be a unique_ptr?

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditpage.cpp
File fpdfsdk/fpdfeditpage.cpp (right):

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditpage.cpp#ne...
fpdfsdk/fpdfeditpage.cpp:162: std::unique_ptr<CPDF_PageObject>
pPageObjHolder(pPageObj);
Move this down to 167 where it is first used? No point to create it if we early
exit.

[Lei Zhang, 2016-07-29 14:46:15]

https://codereview.chromium.org/2195643002/diff/1/core/fpdfapi/fpdf_page/incl...
File core/fpdfapi/fpdf_page/include/cpdf_formobject.h (right):

https://codereview.chromium.org/2195643002/diff/1/core/fpdfapi/fpdf_page/incl...
core/fpdfapi/fpdf_page/include/cpdf_formobject.h:33: std::unique_ptr<CPDF_Form>
m_pForm;
On 2016/07/29 13:22:49, dsinclair wrote:
> Can these be made private: now?

Maybe with a follow up CL to get the other NN places.

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditimg.cpp
File fpdfsdk/fpdfeditimg.cpp (right):

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditimg.cpp#new...
fpdfsdk/fpdfeditimg.cpp:22: pImageObj->m_pImage = new CPDF_Image(pDoc);
On 2016/07/29 13:22:49, dsinclair wrote:
> Should this be a unique_ptr?

No. CPDF_Image is Released half the time. It's wonky.

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditpage.cpp
File fpdfsdk/fpdfeditpage.cpp (right):

https://codereview.chromium.org/2195643002/diff/1/fpdfsdk/fpdfeditpage.cpp#ne...
fpdfsdk/fpdfeditpage.cpp:162: std::unique_ptr<CPDF_PageObject>
pPageObjHolder(pPageObj);
On 2016/07/29 13:22:49, dsinclair wrote:
> Move this down to 167 where it is first used? No point to create it if we
early
> exit.

FPDFPage_InsertObject() has ownership of |page_obj|, so we want to delete it if
we return early. I have a unit test for this, but I can't land the unit test
just yet because CPDF_Image leaks a bit too much.

[dsinclair, 2016-07-30 02:34:00]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-30 02:34:00]

lgtm

[commit-bot: I haz the power, 2016-07-30 02:34:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 02:34:23]

Description was changed from

==========
Simplify some FPDF edit functions.

Fix an unlikely memory leak in FPDFPage_InsertObject().

BUG=pdfium:545
==========

to

==========
Simplify some FPDF edit functions.

Fix an unlikely memory leak in FPDFPage_InsertObject().

BUG=pdfium:545

Committed:
https://pdfium.googlesource.com/pdfium/+/c54bb4340324fab9e860fd625b4b380b6135...
==========

[commit-bot: I haz the power, 2016-07-30 02:34:23]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c54bb4340324fab9e860fd625b4b380b6135...