core/fpdfapi/fpdf_page/include/cpdf_formobject.h - Issue 2195643002: Simplify some FPDF edit functions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fpdfapi/fpdf_page/include/cpdf_formobject.h

Issue 2195643002: Simplify some FPDF edit functions. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 PDFium Authors. All rights reserved.	1 // Copyright 2016 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_	7 #ifndef CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_

8 #define CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_	8 #define CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_

9	9

10 #include <memory>	10 #include <memory>

(...skipping 10 matching lines...) Expand all Loading...
21	21

22 // CPDF_PageObject:	22 // CPDF_PageObject:

23 CPDF_FormObject* Clone() const override;	23 CPDF_FormObject* Clone() const override;

24 Type GetType() const override;	24 Type GetType() const override;

25 void Transform(const CFX_Matrix& matrix) override;	25 void Transform(const CFX_Matrix& matrix) override;

26 bool IsForm() const override;	26 bool IsForm() const override;

27 CPDF_FormObject* AsForm() override;	27 CPDF_FormObject* AsForm() override;

28 const CPDF_FormObject* AsForm() const override;	28 const CPDF_FormObject* AsForm() const override;

29	29

30 void CalcBoundingBox();	30 void CalcBoundingBox();

	31 const CPDF_Form* form() const { return m_pForm.get(); }

31	32

32 std::unique_ptr<CPDF_Form> m_pForm;	33 std::unique_ptr<CPDF_Form> m_pForm;
	dsinclair 2016/07/29 13:22:49 Can these be made private: now? Can these be made private: now? Lei Zhang 2016/07/29 14:46:15 Maybe with a follow up CL to get the other NN plac Show quoted text On 2016/07/29 13:22:49, dsinclair wrote: > Can these be made private: now? Maybe with a follow up CL to get the other NN places.
33 CFX_Matrix m_FormMatrix;	34 CFX_Matrix m_FormMatrix;

34 };	35 };

35	36

36 #endif // CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_	37 #endif // CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_

OLD	NEW

« no previous file with comments | « no previous file | fpdfsdk/fpdfeditimg.cpp » ('j') | fpdfsdk/fpdfeditimg.cpp » ('J')