Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2195523002: Revert of Add color space xform support to SkJpegCodec (includes F16!) (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@drop
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add color space xform support to SkJpegCodec (includes F16!) (patchset #9 id:260001 of https://codereview.chromium.org/2174493002/ ) Reason for revert: Breaking MSAN Original issue's description: > Add color space xform support to SkJpegCodec (includes F16!) > > Also changes SkColorXform to support: > RGBA->RGBA > RGBA->BGRA > > Instead of: > RGBA->SkPMColor > > TBR=reed@google.com > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174493002 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/73d55332e2846dd05e9efdaa2f017bcc3872884b TBR=mtklein@google.com,reed@google.com,herb@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/39979d8c6b97889f600a212cfc9b063360f3de2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -422 lines) Patch
M bench/CodecBench.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M bench/ColorCodecBench.cpp View 4 chunks +43 lines, -24 lines 0 comments Download
M dm/DM.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 3 chunks +63 lines, -32 lines 0 comments Download
M include/codec/SkCodec.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/codec/SkJpegCodec.h View 2 chunks +12 lines, -25 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 15 chunks +98 lines, -186 lines 0 comments Download
M src/core/SkColorSpaceXform.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/core/SkColorSpaceXform.cpp View 4 chunks +3 lines, -40 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/core/SkOpts.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/SkColorXform_opts.h View 6 chunks +31 lines, -64 lines 0 comments Download
M src/opts/SkOpts_sse41.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/viewer/ImageSlide.cpp View 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Add color space xform support to SkJpegCodec (includes F16!)
4 years, 4 months ago (2016-07-29 00:11:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195523002/1
4 years, 4 months ago (2016-07-29 00:11:12 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 00:11:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/39979d8c6b97889f600a212cfc9b063360f3de2f

Powered by Google App Engine
This is Rietveld 408576698