Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: bench/ColorCodecBench.cpp

Issue 2195523002: Revert of Add color space xform support to SkJpegCodec (includes F16!) (Closed) Base URL: https://skia.googlesource.com/skia.git@drop
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « bench/CodecBench.cpp ('k') | dm/DM.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "ColorCodecBench.h" 8 #include "ColorCodecBench.h"
9 #include "Resources.h" 9 #include "Resources.h"
10 #include "SkCodec.h" 10 #include "SkCodec.h"
(...skipping 23 matching lines...) Expand all
34 const char* ColorCodecBench::onGetName() { 34 const char* ColorCodecBench::onGetName() {
35 return fName.c_str(); 35 return fName.c_str();
36 } 36 }
37 37
38 bool ColorCodecBench::isSuitableFor(Backend backend) { 38 bool ColorCodecBench::isSuitableFor(Backend backend) {
39 return kNonRendering_Backend == backend; 39 return kNonRendering_Backend == backend;
40 } 40 }
41 41
42 void ColorCodecBench::decodeAndXform() { 42 void ColorCodecBench::decodeAndXform() {
43 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get())); 43 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get()));
44 SkASSERT(codec); 44 #ifdef SK_DEBUG
45 const SkCodec::Result result =
46 #endif
47 codec->startScanlineDecode(fSrcInfo);
48 SkASSERT(SkCodec::kSuccess == result);
45 49
50 sk_sp<SkColorSpace> srcSpace = sk_ref_sp(codec->getInfo().colorSpace());
51 if (!srcSpace) {
52 srcSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);
53 }
54 std::unique_ptr<SkColorSpaceXform> xform = SkColorSpaceXform::New(srcSpace, fDstSpace);
55 SkASSERT(xform);
56
57 void* dst = fDst.get();
58 for (int y = 0; y < fSrcInfo.height(); y++) {
46 #ifdef SK_DEBUG 59 #ifdef SK_DEBUG
47 SkCodec::Result result = 60 const int rows =
48 #endif 61 #endif
49 codec->getPixels(fDstInfo, fDst.get(), fDstInfo.minRowBytes()); 62 codec->getScanlines(fSrc.get(), 1, 0);
50 SkASSERT(SkCodec::kSuccess == result); 63 SkASSERT(1 == rows);
64
65 FLAGS_half ?
66 xform->applyToF16((uint64_t*) dst, (uint32_t*) fSrc.get(), fSrcI nfo.width()) :
67 xform->applyTo8888((SkPMColor*) dst, (uint32_t*) fSrc.get(), fSr cInfo.width());
68 dst = SkTAddOffset<void>(dst, fDstInfo.minRowBytes());
69 }
51 } 70 }
52 71
53 #if defined(SK_TEST_QCMS) 72 #if defined(SK_TEST_QCMS)
54 void ColorCodecBench::decodeAndXformQCMS() { 73 void ColorCodecBench::decodeAndXformQCMS() {
55 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get())); 74 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get()));
56 #ifdef SK_DEBUG 75 #ifdef SK_DEBUG
57 const SkCodec::Result result = 76 const SkCodec::Result result =
58 #endif 77 #endif
59 codec->startScanlineDecode(fSrcInfo); 78 codec->startScanlineDecode(fSrcInfo);
60 SkASSERT(SkCodec::kSuccess == result); 79 SkASSERT(SkCodec::kSuccess == result);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 } 114 }
96 std::unique_ptr<SkColorSpaceXform> xform = SkColorSpaceXform::New(srcSpace, fDstSpace); 115 std::unique_ptr<SkColorSpaceXform> xform = SkColorSpaceXform::New(srcSpace, fDstSpace);
97 SkASSERT(xform); 116 SkASSERT(xform);
98 117
99 void* dst = fDst.get(); 118 void* dst = fDst.get();
100 void* src = fSrc.get(); 119 void* src = fSrc.get();
101 for (int y = 0; y < fSrcInfo.height(); y++) { 120 for (int y = 0; y < fSrcInfo.height(); y++) {
102 // Transform in place 121 // Transform in place
103 FLAGS_half ? 122 FLAGS_half ?
104 xform->applyToF16((uint64_t*) dst, (uint32_t*) src, fSrcInfo.wid th()) : 123 xform->applyToF16((uint64_t*) dst, (uint32_t*) src, fSrcInfo.wid th()) :
105 xform->applyToRGBA((SkPMColor*) dst, (uint32_t*) src, fSrcInfo.w idth()); 124 xform->applyTo8888((SkPMColor*) dst, (uint32_t*) src, fSrcInfo.w idth());
106 dst = SkTAddOffset<void>(dst, fDstInfo.minRowBytes()); 125 dst = SkTAddOffset<void>(dst, fDstInfo.minRowBytes());
107 src = SkTAddOffset<void>(src, fSrcInfo.minRowBytes()); 126 src = SkTAddOffset<void>(src, fSrcInfo.minRowBytes());
108 } 127 }
109 } 128 }
110 129
111 #if defined(SK_TEST_QCMS) 130 #if defined(SK_TEST_QCMS)
112 void ColorCodecBench::xformOnlyQCMS() { 131 void ColorCodecBench::xformOnlyQCMS() {
113 SkAutoTCallVProc<qcms_profile, qcms_profile_release> 132 SkAutoTCallVProc<qcms_profile, qcms_profile_release>
114 srcSpace(qcms_profile_from_memory(fSrcData->data(), fSrcData->size() )); 133 srcSpace(qcms_profile_from_memory(fSrcData->data(), fSrcData->size() ));
115 SkASSERT(srcSpace); 134 SkASSERT(srcSpace);
(...skipping 15 matching lines...) Expand all
131 // Transform in place 150 // Transform in place
132 qcms_transform_data_type(transform, src, dst, fSrcInfo.width(), outType) ; 151 qcms_transform_data_type(transform, src, dst, fSrcInfo.width(), outType) ;
133 dst = SkTAddOffset<void>(dst, fDstInfo.minRowBytes()); 152 dst = SkTAddOffset<void>(dst, fDstInfo.minRowBytes());
134 src = SkTAddOffset<void>(src, fSrcInfo.minRowBytes()); 153 src = SkTAddOffset<void>(src, fSrcInfo.minRowBytes());
135 } 154 }
136 } 155 }
137 #endif 156 #endif
138 157
139 void ColorCodecBench::onDelayedSetup() { 158 void ColorCodecBench::onDelayedSetup() {
140 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get())); 159 SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded.get()));
160 fSrcInfo = codec->getInfo().makeColorType(kRGBA_8888_SkColorType);
161
162 fDstInfo = fSrcInfo;
163 if (FLAGS_half) {
164 fDstInfo = fDstInfo.makeColorType(kRGBA_F16_SkColorType);
165 }
166 fDst.reset(fDstInfo.getSafeSize(fDstInfo.minRowBytes()));
167
168 if (FLAGS_xform_only) {
169 fSrc.reset(fSrcInfo.getSafeSize(fSrcInfo.minRowBytes()));
170 codec->getPixels(fSrcInfo, fSrc.get(), fSrcInfo.minRowBytes());
171 } else {
172 // Set-up a row buffer to decode into before transforming to dst.
173 fSrc.reset(fSrcInfo.minRowBytes());
174 }
175
141 fSrcData = codec->getICCData(); 176 fSrcData = codec->getICCData();
142 sk_sp<SkData> dstData = SkData::MakeFromFileName( 177 sk_sp<SkData> dstData = SkData::MakeFromFileName(
143 GetResourcePath("monitor_profiles/HP_ZR30w.icc").c_str()); 178 GetResourcePath("monitor_profiles/HP_ZR30w.icc").c_str());
144 SkASSERT(dstData); 179 SkASSERT(dstData);
145 180
146 fDstSpace = nullptr; 181
147 #if defined(SK_TEST_QCMS) 182 #if defined(SK_TEST_QCMS)
148 if (FLAGS_qcms) { 183 if (FLAGS_qcms) {
149 fDstSpaceQCMS.reset(FLAGS_srgb ? 184 fDstSpaceQCMS.reset(FLAGS_srgb ?
150 qcms_profile_sRGB() : 185 qcms_profile_sRGB() :
151 qcms_profile_from_memory(dstData->data(), dstData->size())); 186 qcms_profile_from_memory(dstData->data(), dstData->size()));
152 SkASSERT(fDstSpaceQCMS); 187 SkASSERT(fDstSpaceQCMS);
153 188
154 // This call takes a non-trivial amount of time, but I think it's the mo st fair to 189 // This call takes a non-trivial amount of time, but I think it's the mo st fair to
155 // treat it as overhead. It only needs to happen once. 190 // treat it as overhead. It only needs to happen once.
156 qcms_profile_precache_output_transform(fDstSpaceQCMS); 191 qcms_profile_precache_output_transform(fDstSpaceQCMS);
157 } else 192 } else
158 #endif 193 #endif
159 { 194 {
160 fDstSpace = FLAGS_srgb ? SkColorSpace::NewNamed(SkColorSpace::kSRGB_Name d) : 195 fDstSpace = FLAGS_srgb ? SkColorSpace::NewNamed(SkColorSpace::kSRGB_Name d) :
161 SkColorSpace::NewICC(dstData->data(), dstData-> size()); 196 SkColorSpace::NewICC(dstData->data(), dstData-> size());
162 SkASSERT(fDstSpace); 197 SkASSERT(fDstSpace);
163 } 198 }
164
165 fSrcInfo = codec->getInfo().makeColorType(kRGBA_8888_SkColorType);
166
167 fDstInfo = fSrcInfo.makeColorSpace(fDstSpace);
168 if (FLAGS_half) {
169 fDstInfo = fDstInfo.makeColorType(kRGBA_F16_SkColorType);
170 }
171 fDst.reset(fDstInfo.getSafeSize(fDstInfo.minRowBytes()));
172
173 if (FLAGS_xform_only) {
174 fSrc.reset(fSrcInfo.getSafeSize(fSrcInfo.minRowBytes()));
175 codec->getPixels(fSrcInfo, fSrc.get(), fSrcInfo.minRowBytes());
176 } else if (FLAGS_qcms) {
177 // Set-up a row buffer to decode into before transforming to dst.
178 fSrc.reset(fSrcInfo.minRowBytes());
179 }
180 } 199 }
181 200
182 void ColorCodecBench::onDraw(int n, SkCanvas*) { 201 void ColorCodecBench::onDraw(int n, SkCanvas*) {
183 #if defined(SK_TEST_QCMS) 202 #if defined(SK_TEST_QCMS)
184 bool to8888 = FLAGS_srgb || FLAGS_qcms; 203 bool to8888 = FLAGS_srgb || FLAGS_qcms;
185 #else 204 #else
186 bool to8888 = FLAGS_srgb; 205 bool to8888 = FLAGS_srgb;
187 #endif 206 #endif
188 if (to8888 && FLAGS_half) { 207 if (to8888 && FLAGS_half) {
189 SkDebugf("Error: Contradicting flags.\n"); 208 SkDebugf("Error: Contradicting flags.\n");
(...skipping 12 matching lines...) Expand all
202 #endif 221 #endif
203 { 222 {
204 if (FLAGS_xform_only) { 223 if (FLAGS_xform_only) {
205 this->xformOnly(); 224 this->xformOnly();
206 } else { 225 } else {
207 this->decodeAndXform(); 226 this->decodeAndXform();
208 } 227 }
209 } 228 }
210 } 229 }
211 } 230 }
OLDNEW
« no previous file with comments | « bench/CodecBench.cpp ('k') | dm/DM.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698