Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2195473002:
[Findit] Dashboards and graph for regression range (Closed)
Description[Findit] Dashboards and graph for regression range
BUG=617808
Committed: https://chromium.googlesource.com/infra/infra/+/2d68c6f6e0a70a6fba6ddaaf4d585a6596361665
Patch Set 1 #
Total comments: 8
Patch Set 2 : addressed comments, got code coverage #
Total comments: 8
Patch Set 3 : addressed comments #Patch Set 4 : addressed comments #
Total comments: 19
Patch Set 5 : addressed comments #Patch Set 6 : put dashboard in table #
Total comments: 12
Patch Set 7 : addressed comments #
Messages
Total messages: 25 (5 generated)
view at https://caiw3-dot-findit-for-me.appspot.com/waterfall/flake-dashboard also I don't know the etiquette for this but I haven't written tests for the flake_dashboard, so if I'm not supposed to submit for review until I do that feel free not to review it until I send out another email.
caiw@google.com changed reviewers: + chanli@chromium.org, lijeffrey@chromium.org
looks pretty good so far, just some nits. I'll stop by when you're in to see what the proposed ui looks like and provide comments if needed https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/check_flake.py:31: data = {} you can make this data = { 'success_rates' = [] } https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/check_flake.py:33: for (b_n, s_r) in zip( nit: better to spell out these variables for readability https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... File appengine/findit/handlers/flake/flake_dashboard.py (right): https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/flake_dashboard.py:14: # Get input parameters. what's this Get input parameters about? is this supposed to be a TODO? https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/flake_dashboard.py:18: data = {} nit: you can make this a 1 liner data = { 'master_flake_analyses': master_flake_analyses }
https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/check_flake.py:31: data = {} On 2016/07/29 00:22:55, lijeffrey wrote: > you can make this > > data = { > 'success_rates' = [] > } Done. https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/check_flake.py:33: for (b_n, s_r) in zip( On 2016/07/29 00:22:55, lijeffrey wrote: > nit: better to spell out these variables for readability Done. https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... File appengine/findit/handlers/flake/flake_dashboard.py (right): https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/flake_dashboard.py:14: # Get input parameters. On 2016/07/29 00:22:56, lijeffrey wrote: > what's this Get input parameters about? is this supposed to be a TODO? oops this was all left over from a copy paste https://codereview.chromium.org/2195473002/diff/1/appengine/findit/handlers/f... appengine/findit/handlers/flake/flake_dashboard.py:18: data = {} On 2016/07/29 00:22:55, lijeffrey wrote: > nit: you can make this a 1 liner > > data = { > 'master_flake_analyses': master_flake_analyses > } Done.
https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/handle... File appengine/findit/handlers/flake/test/check_flake_test.py (left): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:3: # found in the LICENSE file. is there a reason for removing this? https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/main.py File appengine/findit/main.py (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/main.p... appengine/findit/main.py:70: ('/waterfall/flake-dashboard', flake_dashboard.FlakeDashboard), nit: these should be alphabetized, so move it down to after /waterfall/failure-log https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... appengine/findit/templates/flake/result.html:34: nit: Not sure if these 2 empty lines should be here. There should be a style guide somewhere but I don't have the link to it at hand
https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/handle... File appengine/findit/handlers/flake/test/check_flake_test.py (left): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:3: # found in the LICENSE file. On 2016/08/01 18:58:39, lijeffrey wrote: > is there a reason for removing this? dunno how that happened... re-added. https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/main.py File appengine/findit/main.py (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/main.p... appengine/findit/main.py:70: ('/waterfall/flake-dashboard', flake_dashboard.FlakeDashboard), On 2016/08/01 18:58:39, lijeffrey wrote: > nit: these should be alphabetized, so move it down to after > /waterfall/failure-log Done. https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... appengine/findit/templates/flake/result.html:34: On 2016/08/01 18:58:39, lijeffrey wrote: > nit: Not sure if these 2 empty lines should be here. There should be a style > guide somewhere but I don't have the link to it at hand Ok I tried to make my code conform to the style guide, which I dug up. My question is: is it ok that I copied this table from stackoverflow?
https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... appengine/findit/templates/flake/result.html:34: On 2016/08/01 19:24:58, caiw wrote: > On 2016/08/01 18:58:39, lijeffrey wrote: > > nit: Not sure if these 2 empty lines should be here. There should be a style > > guide somewhere but I don't have the link to it at hand > > Ok I tried to make my code conform to the style guide, which I dug up. My > question is: is it ok that I copied this table from stackoverflow? Always better to look at sample code to understand it first and come up with your own implementation. In general you should never copy/paste from outside sources or that can lead to trouble. Also extract out the table style to CSS at the top of the file and set it here (look at build_failure.html for sample code) and also be sure to clean up the white space i.e. in line 45 between </div> </td>
https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/20001/appengine/findit/templa... appengine/findit/templates/flake/result.html:34: On 2016/08/01 19:37:28, lijeffrey wrote: > On 2016/08/01 19:24:58, caiw wrote: > > On 2016/08/01 18:58:39, lijeffrey wrote: > > > nit: Not sure if these 2 empty lines should be here. There should be a style > > > guide somewhere but I don't have the link to it at hand > > > > Ok I tried to make my code conform to the style guide, which I dug up. My > > question is: is it ok that I copied this table from stackoverflow? > > Always better to look at sample code to understand it first and come up with > your own implementation. In general you should never copy/paste from outside > sources or that can lead to trouble. > > Also extract out the table style to CSS at the top of the file and set it here > (look at build_failure.html for sample code) and also be sure to clean up the > white space i.e. in line 45 between </div> </td> did the thing with the table style. I couldn't really figure out how to reimplement the table differently since this is really the only way to have a 3x3 table.
If you have a test version, please include it in the description so we can review the UI more easily. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/check_flake.py:1: # Copyright 2016 The Chromium Authors. All rights reserved. Did you overwrite this file by tests by mistake? https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... File appengine/findit/handlers/flake/flake_dashboard.py (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/flake_dashboard.py:14: master_flake_analyses = MasterFlakeAnalysis.query() I think you should use MasterFlakeAnalysis.query().fetch()? https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... File appengine/findit/handlers/flake/test/check_flake_test.py (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:3: from handlers.flake import check_flake This import should be in the same group as below https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:7: from model import analysis_status Move line 6,7 above line 5 https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:25: super(CheckFlakeTest, self).setUp() This setUp can be removed https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:70: self.assertEquals(200, response.status_int) Could you also test if the return value is what you want? you can check build_failure_test.py for reference. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... File appengine/findit/templates/flake/dashboard.html (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/dashboard.html:9: {% for master_flake_analysis in master_flake_analyses %} How about using a table to display data? https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:3: <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> If I remember right, other html files are using utf-8 as charset? https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:7: font-family: Verdana, Arial, sans-serif; font-size: 12px; Place font-size to a separated line
https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:10: width: 450px; height: 200px; nit: Indentation should have 2 spaces #placeholder { width: 450px; height: 200px; } etc
dashboard can be viewed https://caiw3-dot-findit-for-me.appspot.com/waterfall/flake-dashboard https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/check_flake.py:1: # Copyright 2016 The Chromium Authors. All rights reserved. On 2016/08/01 20:42:03, chanli wrote: > Did you overwrite this file by tests by mistake? yes...sorry about that. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... File appengine/findit/handlers/flake/test/check_flake_test.py (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:3: from handlers.flake import check_flake On 2016/08/01 20:42:04, chanli wrote: > This import should be in the same group as below Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:7: from model import analysis_status On 2016/08/01 20:42:04, chanli wrote: > Move line 6,7 above line 5 Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:25: super(CheckFlakeTest, self).setUp() On 2016/08/01 20:42:03, chanli wrote: > This setUp can be removed Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... appengine/findit/handlers/flake/test/check_flake_test.py:70: self.assertEquals(200, response.status_int) On 2016/08/01 20:42:04, chanli wrote: > Could you also test if the return value is what you want? you can check > build_failure_test.py for reference. Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... File appengine/findit/templates/flake/dashboard.html (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/dashboard.html:9: {% for master_flake_analysis in master_flake_analyses %} On 2016/08/01 20:42:04, chanli wrote: > How about using a table to display data? Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:3: <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> On 2016/08/01 20:42:04, chanli wrote: > If I remember right, other html files are using utf-8 as charset? Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:7: font-family: Verdana, Arial, sans-serif; font-size: 12px; On 2016/08/01 20:42:04, chanli wrote: > Place font-size to a separated line Done. https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... appengine/findit/templates/flake/result.html:10: width: 450px; height: 200px; On 2016/08/01 20:54:17, lijeffrey wrote: > nit: Indentation should have 2 spaces > > #placeholder { > width: 450px; > height: 200px; > } > > etc Done.
On 2016/08/02 00:20:38, caiw wrote: > dashboard can be viewed > https://caiw3-dot-findit-for-me.appspot.com/waterfall/flake-dashboard > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > File appengine/findit/handlers/flake/check_flake.py (right): > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > appengine/findit/handlers/flake/check_flake.py:1: # Copyright 2016 The Chromium > Authors. All rights reserved. > On 2016/08/01 20:42:03, chanli wrote: > > Did you overwrite this file by tests by mistake? > > yes...sorry about that. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > File appengine/findit/handlers/flake/test/check_flake_test.py (right): > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > appengine/findit/handlers/flake/test/check_flake_test.py:3: from handlers.flake > import check_flake > On 2016/08/01 20:42:04, chanli wrote: > > This import should be in the same group as below > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > appengine/findit/handlers/flake/test/check_flake_test.py:7: from model import > analysis_status > On 2016/08/01 20:42:04, chanli wrote: > > Move line 6,7 above line 5 > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > appengine/findit/handlers/flake/test/check_flake_test.py:25: > super(CheckFlakeTest, self).setUp() > On 2016/08/01 20:42:03, chanli wrote: > > This setUp can be removed > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/handle... > appengine/findit/handlers/flake/test/check_flake_test.py:70: > self.assertEquals(200, response.status_int) > On 2016/08/01 20:42:04, chanli wrote: > > Could you also test if the return value is what you want? you can check > > build_failure_test.py for reference. > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > File appengine/findit/templates/flake/dashboard.html (right): > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > appengine/findit/templates/flake/dashboard.html:9: {% for master_flake_analysis > in master_flake_analyses %} > On 2016/08/01 20:42:04, chanli wrote: > > How about using a table to display data? > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > File appengine/findit/templates/flake/result.html (right): > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > appengine/findit/templates/flake/result.html:3: <meta http-equiv="Content-Type" > content="text/html; charset=iso-8859-1" /> > On 2016/08/01 20:42:04, chanli wrote: > > If I remember right, other html files are using utf-8 as charset? > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > appengine/findit/templates/flake/result.html:7: font-family: Verdana, Arial, > sans-serif; font-size: 12px; > On 2016/08/01 20:42:04, chanli wrote: > > Place font-size to a separated line > > Done. > > https://codereview.chromium.org/2195473002/diff/60001/appengine/findit/templa... > appengine/findit/templates/flake/result.html:10: width: 450px; height: 200px; > On 2016/08/01 20:54:17, lijeffrey wrote: > > nit: Indentation should have 2 spaces > > > > #placeholder { > > width: 450px; > > height: 200px; > > } > > > > etc > > Done. lgtm
lgtm with nits. Feel free to commit once addressed https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... File appengine/findit/handlers/flake/test/check_flake_test.py (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:57: master_flake_analysis.build_numbers.append(123) nit: use int(build_number) https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:58: master_flake_analysis.success_rates.append(.9) nit: make 0.9 a variable called success_rate then reference it here and in expected_check_flake_result https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:73: 'success_rates': [[123,0.9]] nit: space after , https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... File appengine/findit/templates/flake/dashboard.html (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/dashboard.html:16: <th>Link to graph of regression range</th> How about just "Graph" https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/dashboard.html:34: <input type="submit" value="Look at the graph"> How about just "view" https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/result.html:55: <td> Build Number </td> nit: If it looks ok with out the spaces before/after "Build Number" take them out. Same with regression range of test, pass rate, etc.
On 2016/08/02 21:21:52, lijeffrey wrote: > lgtm with nits. Feel free to commit once addressed > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... > File appengine/findit/handlers/flake/test/check_flake_test.py (right): > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... > appengine/findit/handlers/flake/test/check_flake_test.py:57: > master_flake_analysis.build_numbers.append(123) > nit: use int(build_number) > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... > appengine/findit/handlers/flake/test/check_flake_test.py:58: > master_flake_analysis.success_rates.append(.9) > nit: make 0.9 a variable called success_rate then reference it here and in > expected_check_flake_result > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... > appengine/findit/handlers/flake/test/check_flake_test.py:73: 'success_rates': > [[123,0.9]] > nit: space after , > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... > File appengine/findit/templates/flake/dashboard.html (right): > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... > appengine/findit/templates/flake/dashboard.html:16: <th>Link to graph of > regression range</th> > How about just "Graph" > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... > appengine/findit/templates/flake/dashboard.html:34: <input type="submit" > value="Look at the graph"> > How about just "view" > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... > File appengine/findit/templates/flake/result.html (right): > > https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... > appengine/findit/templates/flake/result.html:55: <td> Build Number </td> > nit: If it looks ok with out the spaces before/after "Build Number" take them > out. Same with regression range of test, pass rate, etc. lgtm
https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... File appengine/findit/handlers/flake/test/check_flake_test.py (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:57: master_flake_analysis.build_numbers.append(123) On 2016/08/02 21:21:51, lijeffrey wrote: > nit: use int(build_number) Done. https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:58: master_flake_analysis.success_rates.append(.9) On 2016/08/02 21:21:51, lijeffrey wrote: > nit: make 0.9 a variable called success_rate then reference it here and in > expected_check_flake_result Done. https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/handl... appengine/findit/handlers/flake/test/check_flake_test.py:73: 'success_rates': [[123,0.9]] On 2016/08/02 21:21:51, lijeffrey wrote: > nit: space after , Done. https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... File appengine/findit/templates/flake/dashboard.html (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/dashboard.html:16: <th>Link to graph of regression range</th> On 2016/08/02 21:21:52, lijeffrey wrote: > How about just "Graph" Done. https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/dashboard.html:34: <input type="submit" value="Look at the graph"> On 2016/08/02 21:21:52, lijeffrey wrote: > How about just "view" Done. https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... File appengine/findit/templates/flake/result.html (right): https://codereview.chromium.org/2195473002/diff/100001/appengine/findit/templ... appengine/findit/templates/flake/result.html:55: <td> Build Number </td> On 2016/08/02 21:21:52, lijeffrey wrote: > nit: If it looks ok with out the spaces before/after "Build Number" take them > out. Same with regression range of test, pass rate, etc. Done.
The CQ bit was checked by caiw@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org, lijeffrey@chromium.org Link to the patchset: https://codereview.chromium.org/2195473002/#ps120001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Findit] Dashboards and graph for regression range BUG=617808 ========== to ========== [Findit] Dashboards and graph for regression range BUG=617808 Committed: https://chromium.googlesource.com/infra/infra/+/2d68c6f6e0a70a6fba6ddaaf4d585... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/infra/infra/+/2d68c6f6e0a70a6fba6ddaaf4d585...
Message was sent while issue was closed.
Patchset #8 (id:140001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
