appengine/findit/templates/flake/result.html - Issue 2195473002: [Findit] Dashboards and graph for regression range

Side by Side Diff: appengine/findit/templates/flake/result.html

Issue 2195473002: [Findit] Dashboards and graph for regression range (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: addressed comments, got code coverage Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <head>	2 <head>

3 <title>Find Regression Range</title>	3 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

4 <meta charset="utf-8">	4 <title> Find Regression Range</title>

	5

	6 <!-- lifted code from http://stackoverflow.com/questions/5563270/axis-label-in-f lot -->

	7

	8 <style type="text/css">

	9 body { font-family: Verdana, Arial, sans-serif; font-size: 12px; }

	10 #placeholder { width: 450px; height: 200px; }

	11 </style>

	12

	13 <script type="text/javascript" language="javascript" src="https://code.jquery.co m/jquery-1.11.3.min.js"></script>

	14 <script type="text/javascript" language="javascript" src="https://cdnjs.cloudfla re.com/ajax/libs/flot/0.8.2/jquery.flot.min.js"></script>

	15 <script type="text/javascript">

	16

	17 $(document).ready(function () {

	18

	19 $.plot($("#placeholder"), [{{success_rates}}],

	20 {

	21 grid: {

	22 hoverable: true,

	23 borderWidth: 1

	24 },

	25 legend: {

	26 labelBoxBorderColor: "none",

	27 position: "right"

	28 }

	29 }

	30 )});

	31 </script>

5 </head>	32 </head>

	33

	34
	lijeffrey 2016/08/01 18:58:39 nit: Not sure if these 2 empty lines should be her nit: Not sure if these 2 empty lines should be here. There should be a style guide somewhere but I don't have the link to it at hand caiw 2016/08/01 19:24:58 Ok I tried to make my code conform to the style gu Show quoted text On 2016/08/01 18:58:39, lijeffrey wrote: > nit: Not sure if these 2 empty lines should be here. There should be a style > guide somewhere but I don't have the link to it at hand Ok I tried to make my code conform to the style guide, which I dug up. My question is: is it ok that I copied this table from stackoverflow? lijeffrey 2016/08/01 19:37:28 Always better to look at sample code to understand Show quoted text On 2016/08/01 19:24:58, caiw wrote: > On 2016/08/01 18:58:39, lijeffrey wrote: > > nit: Not sure if these 2 empty lines should be here. There should be a style > > guide somewhere but I don't have the link to it at hand > > Ok I tried to make my code conform to the style guide, which I dug up. My > question is: is it ok that I copied this table from stackoverflow? Always better to look at sample code to understand it first and come up with your own implementation. In general you should never copy/paste from outside sources or that can lead to trouble. Also extract out the table style to CSS at the top of the file and set it here (look at build_failure.html for sample code) and also be sure to clean up the white space i.e. in line 45 between </div> </td> caiw 2016/08/01 20:07:45 did the thing with the table style. I couldn't re Show quoted text On 2016/08/01 19:37:28, lijeffrey wrote: > On 2016/08/01 19:24:58, caiw wrote: > > On 2016/08/01 18:58:39, lijeffrey wrote: > > > nit: Not sure if these 2 empty lines should be here. There should be a style > > > guide somewhere but I don't have the link to it at hand > > > > Ok I tried to make my code conform to the style guide, which I dug up. My > > question is: is it ok that I copied this table from stackoverflow? > > Always better to look at sample code to understand it first and come up with > your own implementation. In general you should never copy/paste from outside > sources or that can lead to trouble. > > Also extract out the table style to CSS at the top of the file and set it here > (look at build_failure.html for sample code) and also be sure to clean up the > white space i.e. in line 45 between </div> </td> did the thing with the table style. I couldn't really figure out how to reimplement the table differently since this is really the only way to have a 3x3 table.
6 <body>	35 <body>

7 <p> Your job has been submitted. </p>	36 <table style="text-align:center">

	37 <tr>

	38 <td></td>

	39 <td> <h1> Regression range of Test </h1> </td>

	40 <td></td>

	41 </tr>

	42

	43 <tr>

	44 <td> Pass Rate</td>

	45 <td> <div id="placeholder"></div> </td>

	46 <td></td>

	47 </tr>

	48

	49 <tr>

	50 <td></td>

	51 <td> Build Number </td>

	52 <td></td>

	53 </tr>

	54

	55

	56 </table>

8 </body>	57 </body>

	58 </html>

OLD	NEW

« appengine/findit/main.py ('K') | « appengine/findit/templates/flake/dashboard.html ('k') | no next file » | no next file with comments »