Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2195123002: Only setup distillability mojo if needed (Closed)

Created:
4 years, 4 months ago by wychen
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Only setup distillability mojo if needed Prevent extra calls to set up mojo for Reader Mode's distillability logic. Currently the distillability service is set up for any RenderFrameHost that changes (this is not necessarily the main frame) and even if the old service is still alive. This change starts watching for when the service is killed and avoids service setup on non-main frame hosts. BUG=623979 Review-Url: https://codereview.chromium.org/2131343002 Cr-Commit-Position: refs/heads/master@{#404678} (cherry picked from commit 70bb9fd22cc806498fc63a5749fdaaaea7354564) Committed: https://chromium.googlesource.com/chromium/src/+/74bcb27419c3d35e16fffc977ceb32466f5d53b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/dom_distiller/content/browser/distillability_driver.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.cc View 4 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wychen
4 years, 4 months ago (2016-07-30 00:36:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74bcb27419c3d35e16fffc977ceb32466f5d53b8.

Powered by Google App Engine
This is Rietveld 408576698