Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2131343002: Only setup distillability mojo if needed (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
wychen
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only setup distillability mojo if needed Prevent extra calls to set up mojo for Reader Mode's distillability logic. Currently the distillability service is set up for any RenderFrameHost that changes (this is not necessarily the main frame) and even if the old service is still alive. This change starts watching for when the service is killed and avoids service setup on non-main frame hosts. BUG=623979 Committed: https://crrev.com/70bb9fd22cc806498fc63a5749fdaaaea7354564 Cr-Commit-Position: refs/heads/master@{#404678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M components/dom_distiller/content/browser/distillability_driver.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/dom_distiller/content/browser/distillability_driver.cc View 1 4 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mdjones
ptal
4 years, 5 months ago (2016-07-08 17:31:03 UTC) #2
wychen
lgtm https://codereview.chromium.org/2131343002/diff/1/components/dom_distiller/content/browser/distillability_driver.cc File components/dom_distiller/content/browser/distillability_driver.cc (right): https://codereview.chromium.org/2131343002/diff/1/components/dom_distiller/content/browser/distillability_driver.cc#newcode80 components/dom_distiller/content/browser/distillability_driver.cc:80: // This method is invoked if a if ...
4 years, 5 months ago (2016-07-08 23:10:20 UTC) #3
mdjones
https://codereview.chromium.org/2131343002/diff/1/components/dom_distiller/content/browser/distillability_driver.cc File components/dom_distiller/content/browser/distillability_driver.cc (right): https://codereview.chromium.org/2131343002/diff/1/components/dom_distiller/content/browser/distillability_driver.cc#newcode80 components/dom_distiller/content/browser/distillability_driver.cc:80: // This method is invoked if a if any ...
4 years, 5 months ago (2016-07-11 15:50:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131343002/20001
4 years, 5 months ago (2016-07-11 15:51:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 16:58:53 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 16:58:56 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 17:00:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70bb9fd22cc806498fc63a5749fdaaaea7354564
Cr-Commit-Position: refs/heads/master@{#404678}

Powered by Google App Engine
This is Rietveld 408576698