Fix various SkColorSpace bugs

Fix various SkColorSpace bugs

(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194903002

Committed: https://skia.googlesource.com/skia/+/a714bc39294f19500269c8ec536139f75c4b1f25

[msarett, 2016-07-29 13:57:51]

Description was changed from

==========
Fix various SkColorSpace bugs

(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking

BUG=skia:
==========

to

==========
Fix various SkColorSpace bugs

(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194903002
==========

[msarett, 2016-07-29 14:03:50]

msarett@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-07-29 14:47:21]

https://codereview.chromium.org/2194903002/diff/20001/src/core/SkColorSpace_B...
File src/core/SkColorSpace_Base.h (right):

https://codereview.chromium.org/2194903002/diff/20001/src/core/SkColorSpace_B...
src/core/SkColorSpace_Base.h:109: Type type = (&fRedType)[i];
This trick is generally not guaranteed to work when a struct or class isn't
standard layout.  This one is not standard layout because it's got virtual
methods.  To be safe here, just write a switch.

It'd be nice to have the other methods in this class call type() now that it
exists.

[msarett, 2016-07-29 14:56:52]

https://codereview.chromium.org/2194903002/diff/20001/src/core/SkColorSpace_B...
File src/core/SkColorSpace_Base.h (right):

https://codereview.chromium.org/2194903002/diff/20001/src/core/SkColorSpace_B...
src/core/SkColorSpace_Base.h:109: Type type = (&fRedType)[i];
On 2016/07/29 14:47:21, mtklein wrote:
> This trick is generally not guaranteed to work when a struct or class isn't
> standard layout.  This one is not standard layout because it's got virtual
> methods.  To be safe here, just write a switch.
> 

Gotcha sounds good.

> It'd be nice to have the other methods in this class call type() now that it
> exists.

Yes!

[mtklein, 2016-07-29 15:06:06]

lgtm

[msarett, 2016-07-29 15:06:39]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 15:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 15:56:59]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-07-29 15:57:27]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-07-29 15:57:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:58:36]

Description was changed from

==========
Fix various SkColorSpace bugs

(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194903002
==========

to

==========
Fix various SkColorSpace bugs

(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194903002

Committed:
https://skia.googlesource.com/skia/+/a714bc39294f19500269c8ec536139f75c4b1f25
==========

[commit-bot: I haz the power, 2016-07-29 15:58:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a714bc39294f19500269c8ec536139f75c4b1f25