Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2194883002: Remove GetStackTraceLine (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@port-format-stack-trace
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove GetStackTraceLine BUG= Committed: https://crrev.com/e3d1061454c2de011144ea7c670bf6d86589acd1 Cr-Commit-Position: refs/heads/master@{#38215}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M src/contexts.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/execution.cc View 1 2 1 chunk +17 lines, -7 lines 0 comments Download
M src/js/messages.js View 2 chunks +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
jgruber
4 years, 4 months ago (2016-07-29 12:41:35 UTC) #6
Yang
lgtm.
4 years, 4 months ago (2016-08-01 09:06:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194883002/20001
4 years, 4 months ago (2016-08-01 14:41:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/5951) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-01 14:44:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194883002/40001
4 years, 4 months ago (2016-08-01 14:45:59 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 15:08:48 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 15:10:22 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3d1061454c2de011144ea7c670bf6d86589acd1
Cr-Commit-Position: refs/heads/master@{#38215}

Powered by Google App Engine
This is Rietveld 408576698