Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2194703002: Flip all but ios-simulator builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
smut, sdefresne, smut
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip all but ios-simulator builders to GN. This affects: - tryserver.chromium.mac: - ios-device - ios-simulator-cronet - chromium.mac - ios-device - chromium.fyi - ClangToTiOS - EarlGreyiOS This CL also flips the ios-device-gn builder to use the xcode version of Clang so that we can get some coverage of that configuration. The ios-simulator builder will remain on GYP until we drop GYP support. R=sdefresne@chromium.org, smut@chromium.org BUG=621708 Committed: https://crrev.com/628f62988baee46f58385de962f98409d77c17ef Cr-Commit-Position: refs/heads/master@{#408585}

Patch Set 1 #

Total comments: 6

Patch Set 2 : update w review feedback #

Patch Set 3 : update comment #

Patch Set 4 : fix ios-device-gn to not use goma w/ xcode_clang #

Patch Set 5 : fix ios-device, turn off xcode-clang for the moment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M ios/build/bots/chromium.fyi/ClangToTiOS.json View 1 1 chunk +8 lines, -1 line 0 comments Download
M ios/build/bots/chromium.fyi/EarlGreyiOS.json View 1 chunk +8 lines, -1 line 0 comments Download
M ios/build/bots/chromium.mac/ios-device.json View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-device-gn.json View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-cronet.json View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-28 23:50:40 UTC) #1
smut
lgtm https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json#newcode21 ios/build/bots/chromium.fyi/ClangToTiOS.json:21: "target_cpu=\"arm\"" Sort alpha. https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.mac/ios-device-gn.json File ios/build/bots/chromium.mac/ios-device-gn.json (right): https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.mac/ios-device-gn.json#newcode27 ...
4 years, 4 months ago (2016-07-28 23:55:04 UTC) #3
Dirk Pranke
thanks for the review! https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json File ios/build/bots/chromium.fyi/ClangToTiOS.json (right): https://codereview.chromium.org/2194703002/diff/1/ios/build/bots/chromium.fyi/ClangToTiOS.json#newcode21 ios/build/bots/chromium.fyi/ClangToTiOS.json:21: "target_cpu=\"arm\"" On 2016/07/28 23:55:04, smut ...
4 years, 4 months ago (2016-07-29 00:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194703002/40001
4 years, 4 months ago (2016-07-29 00:23:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/43682)
4 years, 4 months ago (2016-07-29 00:30:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194703002/60001
4 years, 4 months ago (2016-07-29 00:41:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/43695)
4 years, 4 months ago (2016-07-29 00:45:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194703002/80001
4 years, 4 months ago (2016-07-29 04:38:35 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-29 05:48:06 UTC) #18
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/628f62988baee46f58385de962f98409d77c17ef Cr-Commit-Position: refs/heads/master@{#408585}
4 years, 4 months ago (2016-07-29 05:49:32 UTC) #20
krasin1
Hi Dirk, looks like this change has broken ios ToT bot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/7908/steps/generate_build_files/logs/stdio
4 years, 4 months ago (2016-08-01 17:58:37 UTC) #21
Dirk Pranke
4 years, 4 months ago (2016-08-01 18:00:39 UTC) #22
Message was sent while issue was closed.
On 2016/08/01 17:58:37, krasin1 wrote:
> Hi Dirk,
> 
> looks like this change has broken ios ToT bot:
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/7908/st...

Yes, thakis has posted a fix: https://codereview.chromium.org/2199833002/

Powered by Google App Engine
This is Rietveld 408576698