public/platform/WebScreenOrientation.h - Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebScreenOrientation.h

Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebScreenOrientation.h

diff --git a/public/platform/WebScreenOrientation.h b/public/platform/WebScreenOrientation.h

index ed9684c8fc15c6139b7e8992ccfd9565ee836c5a..e4b811168f9d1046f3d714ea56b73fee03f0e635 100644

--- a/public/platform/WebScreenOrientation.h

+++ b/public/platform/WebScreenOrientation.h

@@ -5,14 +5,10 @@

#ifndef WebScreenOrientation_h

#define WebScreenOrientation_h

-namespace blink {

+#include "WebScreenOrientationType.h"

+#define WebScreenOrientation WebScreenOrientationType

-enum WebScreenOrientation {

- WebScreenOrientationPortraitPrimary = 1,

- WebScreenOrientationLandscapePrimary = 1 << 1,

- WebScreenOrientationPortraitSecondary = 1 << 2,

- WebScreenOrientationLandscapeSecondary = 1 << 3,

-};

+namespace blink {

typedef unsigned char WebScreenOrientations;

Inactive 2014/04/01 13:20:44 Should we add a FIXME that this file should be rem

mlamouri (slow - plz ping) 2014/04/01 16:30:21 It goes without saying that this should be updated

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « public/platform/Platform.h ('k') | public/platform/WebScreenOrientationListener.h » ('j') | no next file with comments »