public/platform/WebScreenOrientation.h - Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/platform/WebScreenOrientation.h

Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebScreenOrientation_h	5 #ifndef WebScreenOrientation_h

6 #define WebScreenOrientation_h	6 #define WebScreenOrientation_h

7	7

	8 #include "WebScreenOrientationType.h"

	9 #define WebScreenOrientation WebScreenOrientationType

	10

8 namespace blink {	11 namespace blink {

9	12

10 enum WebScreenOrientation {

11 WebScreenOrientationPortraitPrimary = 1,

12 WebScreenOrientationLandscapePrimary = 1 << 1,

13 WebScreenOrientationPortraitSecondary = 1 << 2,

14 WebScreenOrientationLandscapeSecondary = 1 << 3,

15 };

16

17 typedef unsigned char WebScreenOrientations;	13 typedef unsigned char WebScreenOrientations;
	Inactive 2014/04/01 13:20:44 Should we add a FIXME that this file should be rem Should we add a FIXME that this file should be removed once chromium side is updated? mlamouri (slow - plz ping) 2014/04/01 16:30:21 It goes without saying that this should be updated Show quoted text On 2014/04/01 13:20:44, Chris Dumez wrote: > Should we add a FIXME that this file should be removed once chromium side is > updated? It goes without saying that this should be updated. I've added as FIXME to make this clear.
18	14

19 } // namespace blink	15 } // namespace blink

20	16

21 #endif // WebScreenOrientation_h	17 #endif // WebScreenOrientation_h

OLD	NEW

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « public/platform/Platform.h ('k') | public/platform/WebScreenOrientationListener.h » ('j') | no next file with comments »