Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp - Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

Issue 219463003: Screen Orientation API: cleanup, simplify and fix implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientation.cpp ('K') | « Source/modules/screen_orientation/ScreenOrientationDispatcher.h ('k') | public/platform/Platform.h » ('j') | public/platform/WebScreenOrientation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp b/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

index 493e9084daeb15006d19e9dce9b9373ac2094e55..7797c693ba43de31e742c7bdd196cee65dfbd836 100644

--- a/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp

@@ -71,7 +71,7 @@ void ScreenOrientationDispatcher::purgeControllers()

stopListening();

}

-void ScreenOrientationDispatcher::didChangeScreenOrientation(blink::WebScreenOrientation orientation)

+void ScreenOrientationDispatcher::didChangeScreenOrientation(blink::WebScreenOrientationType orientation)

{

TemporaryChange<bool> changeIsDispatching(m_isDispatching, true);