Issue 2194603002: Add UMA to record why chrome shows generic warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2194603002: Add UMA to record why chrome shows generic warning (Closed)

Created:
4 years, 4 months ago by Jialiu Lin

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add UMA to record why chrome shows generic warning Since DownloadProtectionService started to return "UNKOWN" verdict for some types, we need a UMA metrics to track how many generic warnings (Dangerous file warnings) are caused by these UNKOWN verdicts, vs. caused by SAFE verdicts for some types, or the unavailability of SB service. BUG=627244 Review-Url: https://codereview.chromium.org/2160003002 Cr-Commit-Position: refs/heads/master@{#406468} (cherry picked from commit fc3961b8fc2138c497210bc69e6d4321eebad599)

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -2 lines)			Patch
	M	chrome/browser/download/chrome_download_manager_delegate.cc	View		4 chunks	+22 lines, -2 lines	0 comments	Download
	M	tools/metrics/histograms/histograms.xml	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Jialiu Lin

4 years, 4 months ago (2016-07-28 22:28:17 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
eb7564ed2aca262b44e4b49f76908b76299213ac.

Expand Messages | Collapse Messages