Add UMA to record why chrome shows generic warning

Add UMA to record why chrome shows generic warning

Since DownloadProtectionService started to return "UNKOWN" verdict for
some types, we need a UMA metrics to track how many generic warnings
(Dangerous file warnings) are caused by these UNKOWN verdicts,
vs. caused by SAFE verdicts for some types, or the unavailability of SB
service.

BUG=627244
Committed: https://crrev.com/fc3961b8fc2138c497210bc69e6d4321eebad599
Cr-Commit-Position: refs/heads/master@{#406468}

[Jialiu Lin, 2016-07-18 20:41:55]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-07-18 20:43:26]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2016-07-18 20:54:16]

Patchset #2 (id:20001) has been deleted

[Jialiu Lin, 2016-07-18 20:54:45]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-07-18 20:57:35]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2016-07-18 20:59:02]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2016-07-18 20:59:03]

Very short CL for adding UMA to distinguish the reason of generic warning.
nparker@, PTAL. Thanks!

[Nathan Parker, 2016-07-18 21:21:38]

lgtm

https://codereview.chromium.org/2160003002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2160003002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:10609: +    Indicates why a download is
mared as DANGEROUS_FILE. Grouped by reason, such
s/mared/marked

Can you add a comment about how this splits (and should sum to)
Downloads.DangerousDownloadValidated.DANGEROUS_FILE? (Assuming I have that
right.)

[Jialiu Lin, 2016-07-18 21:45:17]

jialiul@chromium.org changed reviewers:
+ holte@chromium.org

[Jialiu Lin, 2016-07-18 21:45:18]

Thanks, nparker@!
Add holte@ for histogram review.

https://codereview.chromium.org/2160003002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2160003002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:10609: +    Indicates why a download is
mared as DANGEROUS_FILE. Grouped by reason, such
On 2016/07/18 at 21:21:38, Nathan Parker wrote:
> s/mared/marked
> 
> Can you add a comment about how this splits (and should sum to)
Downloads.DangerousDownloadValidated.DANGEROUS_FILE? (Assuming I have that
right.)

Done

[Steven Holte, 2016-07-18 22:14:20]

lgtm

[Jialiu Lin, 2016-07-18 22:14:35]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-07-18 22:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2160003002/#ps60001
(title: "refine comment")

[commit-bot: I haz the power, 2016-07-18 22:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:27:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jialiu Lin, 2016-07-18 22:53:31]

jialiul@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Jialiu Lin, 2016-07-18 22:53:31]

+rdsmith@ for owner approval of
chrome/browser/download/chrome_download_manager_delegate.cc

Thanks!

[Randy Smith (Not in Mondays), 2016-07-19 19:30:02]

lgtm

[Jialiu Lin, 2016-07-19 20:07:00]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 23:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 23:33:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jialiu Lin, 2016-07-19 23:40:37]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-07-19 23:41:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:31:27]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-20 02:33:07]

Description was changed from

==========
Add UMA to record why chrome shows generic warning

Since DownloadProtectionService started to return "UNKOWN" verdict for
some types, we need a UMA metrics to track how many generic warnings
(Dangerous file warnings) are caused by these UNKOWN verdicts,
vs. caused by SAFE verdicts for some types, or the unavailability of SB
service.

BUG=627244
==========

to

==========
Add UMA to record why chrome shows generic warning

Since DownloadProtectionService started to return "UNKOWN" verdict for
some types, we need a UMA metrics to track how many generic warnings
(Dangerous file warnings) are caused by these UNKOWN verdicts,
vs. caused by SAFE verdicts for some types, or the unavailability of SB
service.

BUG=627244

Committed: https://crrev.com/fc3961b8fc2138c497210bc69e6d4321eebad599
Cr-Commit-Position: refs/heads/master@{#406468}
==========

[commit-bot: I haz the power, 2016-07-20 02:33:08]

Patchset 3 (id:??) landed as
https://crrev.com/fc3961b8fc2138c497210bc69e6d4321eebad599
Cr-Commit-Position: refs/heads/master@{#406468}