Make chromium_trybots always run layout tests on tryserver.blink bots.

Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary depending on the CL

This is one alternative to http://crrev.com/2190163003.

BUG=631014
Committed: https://chromium.googlesource.com/chromium/tools/build/+/f0cf894af9bbfc9eec5e1237088ea790d25d3008

[qyearsley, 2016-07-28 19:05:32]

Description was changed from

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

BUG=631014
==========

to

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot expectation
files include more tests.

BUG=631014
==========

[qyearsley, 2016-07-28 19:08:29]

Description was changed from

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot expectation
files include more tests.

BUG=631014
==========

to

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

I expect that this change would make tryserver.blink bots always
run layout tests (and other steps including webkit_lint and webkitpy
unit tests), but it would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.

BUG=631014
==========

[qyearsley, 2016-07-28 19:08:30]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-07-28 23:28:56]

Description was changed from

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

I expect that this change would make tryserver.blink bots always
run layout tests (and other steps including webkit_lint and webkitpy
unit tests), but it would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.

BUG=631014
==========

to

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng
builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary
depending on the CL

BUG=631014
==========

[qyearsley, 2016-07-28 23:34:13]

Description was changed from

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng
builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary
depending on the CL

BUG=631014
==========

to

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng
builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary
depending on the CL

This is one alternative to http://crrev.com/2190163003.

BUG=631014
==========

[qyearsley, 2016-07-29 16:18:05]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 16:18:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 16:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 16:25:02]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-07-29 23:59:21]

lgtm

[qyearsley, 2016-07-30 01:07:08]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:11:09]

Description was changed from

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng
builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary
depending on the CL

This is one alternative to http://crrev.com/2190163003.

BUG=631014
==========

to

==========
Make chromium_trybots always run layout tests on tryserver.blink bots.

Note how this makes it so that use_{skia,v8}_patch_on_blink_trybot
simulation expectation files include more tests. The webkit_tests
was in the simulation expectation files for the other blink try bots
because "suppress_analyze" was in the test, but that wasn't in the
step for use_{skia,v8}_patch_on_blink_trybot.

Pros:
 - This makes tryserver.blink bots behave similarly to the *_chromium_rel_ng
builders

Cons
 - This would not make the new
linux_layout_tests_slimming_paint_v2 bot work as it should.
 - This results in running some blink-related tests that may not be necessary
depending on the CL

This is one alternative to http://crrev.com/2190163003.

BUG=631014

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f0cf894af9bbfc9eec5e...
==========

[commit-bot: I haz the power, 2016-07-30 01:11:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f0cf894af9bbfc9eec5e...

[qyearsley, 2016-08-03 21:39:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2206763003/ by qyearsley@chromium.org.

The reason for reverting is: After http://crbug.com/2195223002, layout tests are
not filtered out of the test list for Blink try jobs, so there's no need to add
Blink tests again.

See http://crbug.com/634104..