scripts/slave/recipes/chromium_trybot.py - Issue 2194553002: Make chromium_trybots always run layout tests on tryserver.blink bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 2194553002: Make chromium_trybots always run layout tests on tryserver.blink bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 90827c470e7cecf5e88f6c28bda57b2098d1b737..01daa3a7729ab5a354132d769bf7c84151936ae4 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -148,7 +148,8 @@ def _RunStepsInternal(api):

# TODO(phajdan.jr): Remove special case for layout tests.

add_blink_tests = (affects_blink_paths and

- buildername in CHROMIUM_BLINK_TESTS_BUILDERS)

+ (buildername in CHROMIUM_BLINK_TESTS_BUILDERS or

+ mastername == 'tryserver.blink'))

# Add blink tests that work well with "analyze" here. The tricky ones

# that bypass it (like the layout tests) are added later.

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json » ('j') | no next file with comments »