Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.h

Issue 2194523002: [arc-intents] Handle redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_navigation_throttle.h
diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle.h b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
index 0690af2a6a8951b2f5219f952ffef5cc7425dc5b..8c93d4927df0cada40d6380d0f57ae01b46f889f 100644
--- a/chrome/browser/chromeos/arc/arc_navigation_throttle.h
+++ b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
@@ -57,6 +57,7 @@ class ArcNavigationThrottle : public content::NavigationThrottle {
// content::Navigation implementation:
NavigationThrottle::ThrottleCheckResult WillStartRequest() override;
NavigationThrottle::ThrottleCheckResult WillRedirectRequest() override;
+ NavigationThrottle::ThrottleCheckResult HandleRequest();
djacobo_ 2016/07/28 20:08:01 nit: As HandleRequest() is not an override of cont
Ben Kwa 2016/07/28 21:33:12 Done.
void OnAppCandidatesReceived(mojo::Array<mojom::UrlHandlerInfoPtr> handlers);
void OnAppIconsReceived(
@@ -76,6 +77,8 @@ class ArcNavigationThrottle : public content::NavigationThrottle {
base::WeakPtrFactory<ArcNavigationThrottle> weak_ptr_factory_;
+ CloseReason previous_user_action_;
djacobo_ 2016/07/28 20:08:01 Put this before weak_ptr_factory_, builders are co
Luis Héctor Chávez 2016/07/28 20:12:14 While we're on it, please add a comment to |weak_p
Ben Kwa 2016/07/28 21:33:13 Done.
Ben Kwa 2016/07/28 21:33:13 Done.
+
DISALLOW_COPY_AND_ASSIGN(ArcNavigationThrottle);
};

Powered by Google App Engine
This is Rietveld 408576698