[arc-intents] Handle redirects.

chrome/browser/chromeos/arc/arc_navigation_throttle.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_NAVIGATION_THROTTLE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_NAVIGATION_THROTTLE_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 39 matching lines @@
                           const base::Callback<void(size_t, CloseReason)>& cb)>;
   ArcNavigationThrottle(
       content::NavigationHandle* navigation_handle,
       const ShowDisambigDialogCallback& show_disambig_dialog_cb);
   ~ArcNavigationThrottle() override;
 
  private:
   // content::Navigation implementation:
   NavigationThrottle::ThrottleCheckResult WillStartRequest() override;
   NavigationThrottle::ThrottleCheckResult WillRedirectRequest() override;
+  NavigationThrottle::ThrottleCheckResult HandleRequest();

[djacobo_, 2016/07/28 20:08:01]

nit: As HandleRequest() is not an override of content::Navigation, we should
group this function with OnAppCandidatesReceived.

[Ben Kwa, 2016/07/28 21:33:12]

Done.

 
   void OnAppCandidatesReceived(mojo::Array<mojom::UrlHandlerInfoPtr> handlers);
   void OnAppIconsReceived(
       mojo::Array<mojom::UrlHandlerInfoPtr> handlers,
       std::unique_ptr<ActivityIconLoader::ActivityToIconsMap> icons);
   void OnDisambigDialogClosed(mojo::Array<mojom::UrlHandlerInfoPtr> handlers,
                               size_t selected_app_index,
                               CloseReason close_reason);
   // Compares the host name of the referrer and target URL to decide whether
   // the navigation needs to be overriden.
   bool ShouldOverrideUrlLoading(content::NavigationHandle* navigation_handle);
 
   // A callback object that allow us to display an IntentPicker when Run() is
   // executed, it also allow us to report the user's selection back to
   // OnDisambigDialogClosed().
   ShowDisambigDialogCallback show_disambig_dialog_callback_;
 
   base::WeakPtrFactory<ArcNavigationThrottle> weak_ptr_factory_;
 
+  CloseReason previous_user_action_;

[djacobo_, 2016/07/28 20:08:01]

Put this before weak_ptr_factory_, builders are complaining because of this. 

[Luis Héctor Chávez, 2016/07/28 20:12:14]

While we're on it, please add a comment to |weak_ptr_factory_| mentioning that
it must be the last member so that its destruction can invalidate any in-flight
weak pointers.

[Ben Kwa, 2016/07/28 21:33:13]

Done.

[Ben Kwa, 2016/07/28 21:33:13]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ArcNavigationThrottle);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_NAVIGATION_THROTTLE_H_