Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2194423002: Schedule animation when setting base background color, rather than forcing an update. (Closed)

Created:
4 years, 4 months ago by chrishtr
Modified:
4 years, 4 months ago
Reviewers:
Xianzhu, Sami
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Schedule animation when setting base background color, rather than forcing an update. Also, small cleanup to make FrameView::scheduleRelayoutOfSubtree match FrameView::scheduleRelayout. BUG=591468 Committed: https://crrev.com/eca522bb64cb9a44646a8d2749ec00b768d3490b Cr-Commit-Position: refs/heads/master@{#409352}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Patch Set 6 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
chrishtr
This is only used for one use case in Android webview. This makes it hard ...
4 years, 4 months ago (2016-08-02 15:22:08 UTC) #13
chrishtr
+sami to review throttling changes
4 years, 4 months ago (2016-08-02 16:35:46 UTC) #17
Sami
lgtm. Not sure how feasible it is, but it sure would be swell to have ...
4 years, 4 months ago (2016-08-02 16:52:33 UTC) #20
Xianzhu
lgtm
4 years, 4 months ago (2016-08-02 17:38:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194423002/100001
4 years, 4 months ago (2016-08-02 21:41:13 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-02 22:33:21 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 22:34:36 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/eca522bb64cb9a44646a8d2749ec00b768d3490b
Cr-Commit-Position: refs/heads/master@{#409352}

Powered by Google App Engine
This is Rietveld 408576698