Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2194423002: Schedule animation when setting base background color, rather than forcing an update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 3977 matching lines...) Expand 10 before | Expand all | Expand 10 after
3988 3988
3989 void WebViewImpl::setBaseBackgroundColor(WebColor color) 3989 void WebViewImpl::setBaseBackgroundColor(WebColor color)
3990 { 3990 {
3991 if (m_baseBackgroundColor == color) 3991 if (m_baseBackgroundColor == color)
3992 return; 3992 return;
3993 3993
3994 m_baseBackgroundColor = color; 3994 m_baseBackgroundColor = color;
3995 3995
3996 if (m_page->mainFrame() && m_page->mainFrame()->isLocalFrame()) 3996 if (m_page->mainFrame() && m_page->mainFrame()->isLocalFrame())
3997 m_page->deprecatedLocalMainFrame()->view()->setBaseBackgroundColor(color ); 3997 m_page->deprecatedLocalMainFrame()->view()->setBaseBackgroundColor(color );
3998
3999 updateAllLifecyclePhases();
4000 } 3998 }
4001 3999
4002 void WebViewImpl::setIsActive(bool active) 4000 void WebViewImpl::setIsActive(bool active)
4003 { 4001 {
4004 if (page()) 4002 if (page())
4005 page()->focusController().setActive(active); 4003 page()->focusController().setActive(active);
4006 } 4004 }
4007 4005
4008 bool WebViewImpl::isActive() const 4006 bool WebViewImpl::isActive() const
4009 { 4007 {
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
4620 return nullptr; 4618 return nullptr;
4621 return focusedFrame; 4619 return focusedFrame;
4622 } 4620 }
4623 4621
4624 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const 4622 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const
4625 { 4623 {
4626 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr; 4624 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
4627 } 4625 }
4628 4626
4629 } // namespace blink 4627 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698