Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2194383005: Enforce can_use_on_swarming_builders on all tests. (Closed)

Created:
4 years, 4 months ago by M-A Ruel
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce can_use_on_swarming_builders on all tests. This in preparation to eventually toggling the switch. R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/3233f709f729aae639bb68fed2a25d03793792a0 Cr-Commit-Position: refs/heads/master@{#416054}

Patch Set 1 : Enforce can_use_on_swarming_builders on all tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 11 chunks +495 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 11 chunks +33 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
M-A Ruel
4 years, 3 months ago (2016-09-01 15:23:48 UTC) #6
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-01 19:40:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194383005/20001
4 years, 3 months ago (2016-09-01 20:11:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-01 21:12:10 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3233f709f729aae639bb68fed2a25d03793792a0 Cr-Commit-Position: refs/heads/master@{#416054}
4 years, 3 months ago (2016-09-01 21:14:21 UTC) #13
Ken Russell (switch to Gerrit)
This should not have touched chromium.gpu.json or chromium.gpu.fyi.json. As mentioned prominently at the top of ...
4 years, 3 months ago (2016-09-01 22:53:19 UTC) #15
ynovikov
4 years, 3 months ago (2016-09-01 23:10:30 UTC) #16
Message was sent while issue was closed.
On 2016/09/01 22:53:19, Ken Russell wrote:
> This should not have touched chromium.gpu.json or chromium.gpu.fyi.json. As
> mentioned prominently at the top of the files, they are autogenerated.

Fixing chromium.gpu.fyi.json in https://codereview.chromium.org/2305453004/

Powered by Google App Engine
This is Rietveld 408576698