Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194383002: Converted Observatory code-ref function-ref element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added qualified flag #

Total comments: 4

Patch Set 3 : Fixed style problems #

Patch Set 4 : Fixed wrong FunctionKind values #

Patch Set 5 : Fixed CSS problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -238 lines) Patch
M runtime/observatory/lib/cpu_profile.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/debugger.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.dart View 1 2 3 6 chunks +10 lines, -2 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/debugger/debugger_location.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 1 chunk +49 lines, -20 lines 0 comments Download
D runtime/observatory/lib/src/elements/code_ref.html View 1 chunk +0 lines, -8 lines 0 comments Download
A runtime/observatory/lib/src/elements/code_ref_wrapper.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 2 3 5 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 4 2 chunks +64 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 1 chunk +68 lines, -31 lines 0 comments Download
D runtime/observatory/lib/src/elements/function_ref.html View 1 chunk +0 lines, -9 lines 0 comments Download
A runtime/observatory/lib/src/elements/function_ref_wrapper.dart View 1 1 chunk +59 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instructions_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_ref_wrapper.dart View 1 chunk +8 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/logging.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_ref_wrapper.dart View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/source_link_wrapper.dart View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/mocks/objects/code.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/mocks/objects/function.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/class.dart View 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/lib/src/models/objects/code.dart View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/function.dart View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 9 chunks +50 lines, -92 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/code_ref/element_test.dart View 1 chunk +11 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/code_ref/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/function_ref/element_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/function_ref/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate_ref/element_test.dart View 2 chunks +14 lines, -20 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate_ref/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-01 21:45:59 UTC) #2
Cutch
This mostly looks good but the enum value cases are all wrong https://codereview.chromium.org/2194383002/diff/20001/runtime/observatory/lib/src/models/objects/code.dart File runtime/observatory/lib/src/models/objects/code.dart ...
4 years, 4 months ago (2016-08-01 22:24:26 UTC) #3
Cutch
LGTM after addressing previous comments
4 years, 4 months ago (2016-08-01 22:36:32 UTC) #4
cbernaschina
https://codereview.chromium.org/2194383002/diff/20001/runtime/observatory/lib/src/models/objects/code.dart File runtime/observatory/lib/src/models/objects/code.dart (right): https://codereview.chromium.org/2194383002/diff/20001/runtime/observatory/lib/src/models/objects/code.dart#newcode8 runtime/observatory/lib/src/models/objects/code.dart:8: Dart, On 2016/08/01 22:24:26, Cutch wrote: > The Dart ...
4 years, 4 months ago (2016-08-01 22:45:51 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-02 00:21:07 UTC) #6
cbernaschina
4 years, 4 months ago (2016-08-02 00:23:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
e76ad0353b56de0bca2cb3c29cc281612e964b2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698