Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile.dart

Issue 2194383002: Converted Observatory code-ref function-ref element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fixed CSS problem Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile.dart b/runtime/observatory/lib/src/elements/cpu_profile.dart
index 305706adba8e67416bb10b7ff5c4ba5d34eb1329..82f479d00e370e27122b69741a7412bd50061b6b 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile.dart
@@ -7,6 +7,7 @@ library cpu_profile_element;
import 'dart:async';
import 'dart:html';
import 'observatory_element.dart';
+import 'package:observatory/models.dart' as M;
import 'package:observatory/service.dart';
import 'package:observatory/app.dart';
import 'package:observatory/cpu_profile.dart';
@@ -347,7 +348,7 @@ class FunctionProfileTreeRow extends ProfileTreeRow<FunctionCallTreeNode> {
makeInfoBox();
functionRow.children.add(infoBox);
- if (node.profileFunction.function.kind.hasDartCode()) {
+ if (M.hasDartCode(node.profileFunction.function.kind)) {
infoBox.children.add(div('Code for current node'));
infoBox.children.add(br());
var totalTicks = node.totalCodesTicks;
@@ -393,7 +394,7 @@ class FunctionProfileTreeRow extends ProfileTreeRow<FunctionCallTreeNode> {
'Call stack time' : node.profileFunction.formattedOnStackTime,
});
- if (node.profileFunction.function.kind.hasDartCode()) {
+ if (M.hasDartCode(node.profileFunction.function.kind)) {
infoBox.children.add(div('Code containing function'));
infoBox.children.add(br());
var totalTicks = profile.sampleCount;
@@ -647,7 +648,7 @@ class FunctionCallTreeNodeRow extends VirtualTreeRow {
FunctionCallTreeNode node)
: node = node,
super(tree, depth) {
- if ((node.profileFunction.function.kind == FunctionKind.kTag) &&
+ if ((node.profileFunction.function.kind == M.FunctionKind.tag) &&
(node.profileFunction.normalizedExclusiveTicks == 0) &&
(node.profileFunction.normalizedInclusiveTicks == 0)) {
selfPercent = '';
@@ -735,7 +736,7 @@ class CodeCallTreeNodeRow extends VirtualTreeRow {
CodeCallTreeNode node)
: node = node,
super(tree, depth) {
- if ((node.profileCode.code.kind == CodeKind.Tag) &&
+ if ((node.profileCode.code.kind == M.CodeKind.tag) &&
(node.profileCode.normalizedExclusiveTicks == 0) &&
(node.profileCode.normalizedInclusiveTicks == 0)) {
selfPercent = '';
« no previous file with comments | « runtime/observatory/lib/src/elements/context_view.html ('k') | runtime/observatory/lib/src/elements/cpu_profile.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698