Issue 219433005: Move gtest/gmock BUILD.gn files to main tree.

Issue 219433005: Move gtest/gmock BUILD.gn files to main tree. (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move gtest/gmock BUILD.gn files to main tree. Also moves the "unused variable warning" to a config in the build directory so it can be shared with outher targets without duplication on the command line. BUG= R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260949

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -134 lines)			Patch
M	build/config/win/BUILD.gn	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	testing/gmock/BUILD.gn	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	testing/gtest/BUILD.gn	View	2 chunks	+5 lines, -4 lines	0 comments	Download
D	tools/gn/secondary/testing/gmock/BUILD.gn	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	tools/gn/secondary/testing/gtest/BUILD.gn	View	1 chunk	+0 lines, -84 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #1 manually as r260949 (presubmit successful).

6 years, 8 months ago (2014-04-01 21:47:56 UTC) #3

rlarocque

6 years, 8 months ago (2014-04-01 22:00:06 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/221443005/ by rlarocque@chromium.org.

The reason for reverting is: Causing breakage on the buildbots.

http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/1429/ is
one example.

________ running 'svn update /Volumes/data/b/build/slave/Mac_Builder/build/src
--revision 260951 --force --accept theirs-conflict --ignore-externals' in
'/Volumes/data/b/build/slave/Mac_Builder/build'
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/build/config/win/BUILD.gn
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/item.h
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/command_gen.cc
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/gn.gyp
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/BUILD.gn
A    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/visibility.cc
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/builder.h
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/functions.cc
A    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/visibility.h
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/variables.cc
U   
/Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/function_toolchain.cc
A   
/Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/visibility_unittest.cc
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/variables.h
D   
/Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/secondary/testing
U    /Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/builder.cc
U   
/Volumes/data/b/build/slave/Mac_Builder/build/src/tools/gn/target_generator.cc
svn: UUID mismatch: existing directory
'/Volumes/data/b/build/slave/Mac_Builder/build/src/testing/gtest' was checked
out from a different repository
Sleeping 5.0 seconds and retrying.....

Expand Messages | Collapse Messages