extensions/browser/app_window/app_window.h - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.h

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.h

diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h

index 1e30bab83f4e42725ef6e9ecc69b45b01c8a9212..7a4aac4017c1159980658325069a074c259f5cc3 100644

--- a/extensions/browser/app_window/app_window.h

+++ b/extensions/browser/app_window/app_window.h

@@ -389,7 +389,8 @@ class AppWindow : public content::WebContentsDelegate,

// content::WebContentsDelegate implementation.

void CloseContents(content::WebContents* contents) override;

- bool ShouldSuppressDialogs(content::WebContents* source) override;

+ bool ShouldSuppressDialogs(content::WebContents* source,

+ bool before_unload) override;

content::ColorChooser* OpenColorChooser(

content::WebContents* web_contents,

SkColor color,

« no previous file with comments | « content/public/browser/web_contents_delegate.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »